Replace THistSvc with Monitored infrastructure for inputs (!60338) · Merge requests · atlas / athena · GitLab

Snippets Groups Projects

Merged Gabriel Oliveira Correa requested to merge oliveirg/athena:L1TopoMon into master 2 years ago

Replace THistSvc with the "Monitored" infrastructure for the histograms from the input providers. Related: ATR-26402

Tagging @asonay

Edited 2 years ago by Gabriel Oliveira Correa

Activity

Gabriel Oliveira Correa added 1 commit 2 years ago
added 1 commit

36911720 - Replace THistSvc with Monitored infrasctructure for gFex, eFex, and jFex

Compare with previous version
Gabriel Oliveira Correa added 1 commit 2 years ago
added 1 commit

2d78a495 - Replace THistSvc with Monitored infrasctructure for legacy inputs

Compare with previous version
Gabriel Oliveira Correa added 1 commit 2 years ago
added 1 commit

cab03f5e - Remove THistSvc remains

Compare with previous version
Gabriel Oliveira Correa marked this merge request as ready 2 years ago

marked this merge request as ready
Gabriel Oliveira Correa changed the description 2 years ago

changed the description
ATLAS Robot @atlasbot · 2 years ago

Developer
This merge request affects 1 package:

Trigger/TrigT1/L1Topo/L1TopoSimulation

This merge request affects 16 files:

Trigger/TrigT1/L1Topo/L1TopoSimulation/python/L1TopoInputHistograms.py

Trigger/TrigT1/L1Topo/L1TopoSimulation/python/L1TopoSimulationConfig.py

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EMTauInputProvider.cxx

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EMTauInputProvider.h

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EnergyInputProvider.cxx

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EnergyInputProvider.h

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/JetInputProvider.cxx

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/JetInputProvider.h

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/MuonInputProvider.cxx

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/MuonInputProvider.h

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/eFexInputProvider.cxx

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/eFexInputProvider.h

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/gFexInputProvider.cxx

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/gFexInputProvider.h

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/jFexInputProvider.cxx

Trigger/TrigT1/L1Topo/L1TopoSimulation/src/jFexInputProvider.h

Adding @jchapman ,@serodrig ,@jmharris ,@iriu ,@oliveirg ,@orlando ,@cmorenom ,@paulama ,@asonay as watchers
ATLAS Robot added JetEtmiss Tau Trigger master review-pending-level-1 labels 2 years ago

added JetEtmiss Tau Trigger master review-pending-level-1 labels
ATLAS Robot @atlasbot · 2 years ago

Developer

CI Result SUCCESS (hash cab03f5e)

Athena

externals

cmake

make

tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65893]
Frank Winklmeier @fwinkl started a thread on an old version of the diff 2 years ago

Resolved 2 years ago by Gabriel Oliveira Correa
Last reply by Frank Winklmeier 2 years ago

Frank Winklmeier added label 2 years ago

added review-user-action-required label

Frank Winklmeier removed label 2 years ago

removed review-pending-level-1 label

Gabriel Oliveira Correa added 1 commit 2 years ago

added 1 commit

d2f2f188 - Explicitly pass the flags to the GenericMonitoringTool

Compare with previous version

ATLAS Robot @atlasbot · 2 years ago

Developer

This merge request affects 1 package:

Trigger/TrigT1/L1Topo/L1TopoSimulation

This merge request affects 16 files:

Trigger/TrigT1/L1Topo/L1TopoSimulation/python/L1TopoInputHistograms.py
Trigger/TrigT1/L1Topo/L1TopoSimulation/python/L1TopoSimulationConfig.py
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EMTauInputProvider.cxx
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EMTauInputProvider.h
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EnergyInputProvider.cxx
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/EnergyInputProvider.h
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/JetInputProvider.cxx
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/JetInputProvider.h
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/MuonInputProvider.cxx
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/MuonInputProvider.h
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/eFexInputProvider.cxx
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/eFexInputProvider.h
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/gFexInputProvider.cxx
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/gFexInputProvider.h
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/jFexInputProvider.cxx
Trigger/TrigT1/L1Topo/L1TopoSimulation/src/jFexInputProvider.h

Adding @jchapman ,@serodrig ,@jmharris ,@iriu ,@oliveirg ,@orlando ,@cmorenom ,@paulama ,@asonay as watchers

ATLAS Robot added label and removed label 2 years ago

added review-pending-level-1 label and removed review-user-action-required label

Gabriel Oliveira Correa resolved all threads 2 years ago

resolved all threads

ATLAS Robot @atlasbot · 2 years ago

Developer

CI Result SUCCESS (hash d2f2f188)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65966]

Karolos Potamianos @karolos · 2 years ago

Owner

Looks good. Karolos (L2)

Karolos Potamianos added label and removed label 2 years ago

added review-approved label and removed review-pending-level-1 label

J

Julien Maurer @jmaurer · 2 years ago

Developer

Resolved 2 years ago by Julien Maurer

can you please confirm that this has been tested?
Last reply by Julien Maurer 2 years ago

Julien Maurer resolved all threads 2 years ago

resolved all threads

Please register or sign in to reply