Skip to content
Snippets Groups Projects

ATR-24438: switch to AllTag and AllProbe menu alignment groups

Merged Stefanie Morgenstern requested to merge shanisch/athena:ATR-24438_menuAlignment23 into master

tagging @astruebi , @lidiaz , @tamartin , @sshaw , @fpastore

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • No comments from me, but will mark as review-user-action-required while the open threads are being resolved
    Albert (L1)

  • Thanks @shanisch !!

    One thing to note - we will conflict against !60135 (merged) and I don't think there is anything really we can do to avoid this.

    But after that, hopefully @lidiaz & @astruebi can help coordinate on the menu side to avoid further conflicts.

  • yes, this probably will require some rebasing, no problem with that but would be good to schedule this MR to avoid to have to do this multiple times :)

  • Antonia Strubig resolved all threads

    resolved all threads

  • added 725 commits

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @martindl ,@ademaria ,@dbakshig ,@vmartin ,@okumura ,@carquin ,@jodafons ,@bernius ,@safarzad ,@shanisch ,@gipezzul ,@lidiaz ,@sutt ,@salderwe ,@iriu ,@fernando ,@hrussell ,@malconad ,@cjmeyer ,@eegidiop as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 196K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 324K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • :x: CI Result FAILURE (hash cac636b9)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66220]

  • added 18 commits

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @martindl ,@ademaria ,@dbakshig ,@vmartin ,@okumura ,@carquin ,@jodafons ,@bernius ,@safarzad ,@shanisch ,@gipezzul ,@lidiaz ,@sutt ,@salderwe ,@iriu ,@fernando ,@hrussell ,@malconad ,@cjmeyer ,@eegidiop as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 196K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 324K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • :white_check_mark: CI Result SUCCESS (hash da456980)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66237]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading