Layers avoid use after move

I assume this is used only in the ITK path.

The change is

, Layer(std::move(surfaceArray), thickness, std::move(olap), laytyp)
 .... 
{
  if (!ades && surfaceArray) <-- [surfaceArray has been moved from above]

to

, Layer(std::move(surfaceArray), thickness, std::move(olap), laytyp)
 .... 
{
  if (!ades && m_surfaceArray) <-- [m_surfaceArray has been moved to]

More or less the issue is this [https://godbolt.org/z/jqavj6YGe]

ping @tstreble @pagessin

added bugfix label

mentioned in merge request !59913 (merged)

This merge request affects 1 package:

• Tracking/TrkDetDescr/TrkGeometry

This merge request affects 2 files:

• Tracking/TrkDetDescr/TrkGeometry/src/CylinderLayer.cxx
• Tracking/TrkDetDescr/TrkGeometry/src/DiscLayer.cxx

Adding @amorley as watcher

added Tracking master review-pending-level-1 labels

changed the description

CI Result SUCCESS (hash 7acc55bb)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65771]

Approved
Albert (L1)

added review-approved label and removed review-pending-level-1 label

I see the extrapolation fixed with this MR:

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit 3184b362

merged

added sweep:ignore label