Skip to content
Snippets Groups Projects

Initial Conversion BLS Triggers to CA

Merged Adam Edward Barton requested to merge abarton/athena:BLSCA into master
All threads resolved!

This seems not to break legacy jobs. Not sure how compatible it is with CA mode yet.

@lyubushk @fpastore @fwinkl for comments

kwargs are used for a complicated configuration but encapsulated in a single file.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 2 years ago (Feb 10, 2023 7:14pm UTC)

Merge details

  • Changes merged into master with 1f96f17c (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Winklmeier
  • This merge request affects 1 package:

    • Trigger/TrigHypothesis/TrigBphysHypo

    This merge request affects 5 files:

    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBPhyCommonCfg.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmumuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBphysStreamerHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigMultiTrkComboHypoConfig.py

    Adding @lyubushk ,@abarton as watchers

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash e7c36daa)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65895]

  • Frank Winklmeier resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigHypothesis/TrigBphysHypo

    This merge request affects 5 files:

    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBPhyCommonConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmumuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBphysStreamerHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigMultiTrkComboHypoConfig.py

    Adding @lyubushk ,@abarton as watchers

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 1e972f13)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65905]

  • Just a few comments to consider related to the configs of the new tools introduced.

    Best, Thomas (L1)

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigHypothesis/TrigBphysHypo

    This merge request affects 5 files:

    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBPhyCommonConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmumuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBphysStreamerHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigMultiTrkComboHypoConfig.py

    Adding @lyubushk ,@abarton as watchers

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigHypothesis/TrigBphysHypo

    This merge request affects 5 files:

    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBPhyCommonConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmumuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBmuxComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBphysStreamerHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigMultiTrkComboHypoConfig.py

    Adding @lyubushk ,@abarton as watchers

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 60104f42)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65929]

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 9fd7988c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65930]

  • Adam Edward Barton resolved all threads

    resolved all threads

  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Adam Edward Barton resolved all threads

    resolved all threads

  • added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton resolved all threads

    resolved all threads

  • mentioned in commit 1f96f17c

  • Please register or sign in to reply
    Loading