athenaHLT: move post-exec into central places
When running the HLT, we used several post-execs after the user job options to ensure certain services and CondAlgs are configured correctly. Move all these settings into the source packages and use the Trigger.Online.isPartition
flag to check if we are running the HLT (for legacy job options, we are using isOnline
and the existence of HltEventLoopMgr
). To make sure these settings are not being tinkered with, !60477 (merged) has introduced a check in the CI for the correct values of these job options.
Also, use a locked clone of the flags for TrigServicesCfg
. The main flags need to remain unlocked until the user job options are parsed.
Relates to ATR-26800.
Merge request reports
Activity
added full-unit-tests label
This merge request affects 7 packages:
- Database/IOVDbSvc
- HLT/Trigger/TrigControl/TrigPSC
- HLT/Trigger/TrigControl/TrigServices
- InnerDetector/InDetConditions/BeamSpotConditions
- LumiBlock/LumiBlockComps
- MagneticField/MagFieldServices
- Trigger/TrigConfiguration/TrigConfigSvc
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@asonay ,@orlando ,@sroe ,@wiedenma ,@jmharris ,@cmorenom ,@bernius ,@tamartin ,@paulama ,@oliveirg ,@fwinkl ,@ssnyder ,@mark ,@rbielski as watchers
added DQ Database InnerDetector Magnets Trigger master review-pending-level-1 labels
CI Result FAILURE (hash 6f14ef51)Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65970]removed review-pending-level-1 label
added review-user-action-required label
added 6 commits
- 80287986 - MagFieldServices: load field map on start for HLT
- 59fc2e2f - TrigConfigSvc: add HLT prescale folder as extensible
- b661886f - IOVDbSvc: set special cache settings for HLT
- 123b1b14 - LumiBlockComps: add online lumi folder as extensible for HLT
- 1919563c - BeamSpotConditions: add beamspot folder as extensible for HLT
- bd6a8fa4 - TrigPSC+TrigServices: remove post-config settings
Toggle commit listThis merge request affects 7 packages:
- Database/IOVDbSvc
- HLT/Trigger/TrigControl/TrigPSC
- HLT/Trigger/TrigControl/TrigServices
- InnerDetector/InDetConditions/BeamSpotConditions
- LumiBlock/LumiBlockComps
- MagneticField/MagFieldServices
- Trigger/TrigConfiguration/TrigConfigSvc
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@asonay ,@orlando ,@sroe ,@wiedenma ,@jmharris ,@cmorenom ,@bernius ,@tamartin ,@paulama ,@oliveirg ,@fwinkl ,@ssnyder ,@mark ,@rbielski as watchers
added review-pending-level-1 label and removed review-user-action-required label
- Resolved by Frank Winklmeier
In the end I had to change from using
isOnline/doHLT
toTrigger.Online.isPartition
as some of these settings (e.g. loading the field map on start) doesn't even work in plain athena when running runHLT_standalone.
removed review-pending-level-1 label
added review-user-action-required label
CI Result FAILURE (hash bd6a8fa4)Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66021]added 6 commits
- eafadc97 - MagFieldServices: load field map on start for HLT
- a6112d7e - TrigConfigSvc: add HLT prescale folder as extensible
- f2147d13 - IOVDbSvc: set special cache settings for HLT
- 813e4eb1 - LumiBlockComps: add online lumi folder as extensible for HLT
- c6520e4e - BeamSpotConditions: add beamspot folder as extensible for HLT
- 9fe38677 - TrigPSC+TrigServices: remove post-config settings
Toggle commit listThis merge request affects 7 packages:
- Database/IOVDbSvc
- HLT/Trigger/TrigControl/TrigPSC
- HLT/Trigger/TrigControl/TrigServices
- InnerDetector/InDetConditions/BeamSpotConditions
- LumiBlock/LumiBlockComps
- MagneticField/MagFieldServices
- Trigger/TrigConfiguration/TrigConfigSvc
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@asonay ,@orlando ,@sroe ,@wiedenma ,@jmharris ,@cmorenom ,@bernius ,@tamartin ,@paulama ,@oliveirg ,@fwinkl ,@ssnyder ,@mark ,@rbielski as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILURE (hash 9fe38677)Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66029]added review-user-action-required label and removed review-pending-level-1 label