eFexTowerBuilder redesign, and new algorithm to convert eFexTowers to eTowers in the L1CaloFEX simulation

• eFexTowerBuilder redesign that will take the mapping from a given file, or otherwise try to generate it in the first event.
• eTowerMakerFromEfexTowers algorithm that produces a collection of eTowers from eFexTowers

The mapping file for the eFexTowerBuilder needs adding to the calib file area so I should do that before we accept this MR so that I can update the path in the algo property. Link to calibarea upload request: https://its.cern.ch/jira/browse/ATLASG-2463

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added Trigger master review-pending-level-1 labels

changed the description

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 973ef59a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66158]

i dont see how the test failure could have been caused by this??

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 973ef59a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66248]

Looks good. L1

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added review-user-action-required label

added 1 commit

• e5cd695d - update cpoyrights

Compare with previous version

resolved all threads

removed review-user-action-required label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added review-pending-level-1 label and removed review-approved review-approved-point1 labels

Build area was cleaned as per request posted in the DB. The full software build will be performed

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

removed review-pending-level-1 label

added review-approved review-approved-point1 labels

CI Result SUCCESS (hash e5cd695d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66281]

merged

mentioned in commit b0b3412a

added sweep:ignore label