Skip to content

AsgComponentConfig Re-Design, master branch (2023.02.21.)

Attila Krasznahorkay requested to merge akraszna/athena:AsgComponentConfigRedesign-master-20230221 into master

Changed one of the internal variables of asg::AsgComponentConfig. The type used so far is just not sitting well with ROOT I/O. (See: https://github.com/root-project/root/issues/12358) So rather than using an std::tuple type, switched to using a simple struct instead.

Also added a unit test that would test the type of I/O which would fail with the previous implementation of asg::AsgComponentConfig, but would succeed with this re-designed setup.

This is a follow-up from !60343 (merged), which unfortunately did not manage to fix ATLASG-2456 in the end. 😦 But this one should. 🤞

Pinging @krumnack.

Merge request reports