gFEX Towers Decorator

With this MR, the decoration of decoded input gTowers with corresponding SuperCell and Tile tower information is implemented. The purpose is to enable a comparison between the decoded gTowers and decoded SuperCells and Tile Towers to make sure that the assignment is done correctly and to use it as a tool for monitoring. It makes use of maps containing the relevant information (which SC/Tile towers are assigned to which gTowers?). The files with the maps are currently located in a personal public area, however, a request has been submitted for moving those files into CVMFS (ATLASG-2469). Additionally, the masking of the SuperCells has been enabled in the gFex mapping simulation.

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added Trigger master review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 07696497)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66917]

I've just shared a few style comments to consider.

Best, Thomas - L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• c41518e7 - Address style comments

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

resolved all threads

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash c41518e7)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 66967]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• e7b46d22 - Remove useless pointers and other style changes

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash e7b46d22)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67086]

added 1 commit

• 6107b2a8 - Remove white spaces when reading files

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 6107b2a8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67087]

Failure also seen in nightly https://its.cern.ch/jira/projects/ATR/issues/ATR-27019

Edit: the issue is actually different, apologies for the wrong statement

Just one minor comment, otherwise the changes look fine.

Jason (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• de153d43 - Remove remaining comments

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXAlgos
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @thompson ,@serodrig as watchers

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash de153d43)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67133]

The changes look fine and the CI issue is unrelated. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

I don't think we can merge this with an input file on afs. Jobs running at P1 or on the grid will not have access to this. This can be merged only when the input file is in a distributed location

removed review-approved label

removed review-approved-tier0 label