Legacy jet slice with MenuSequenceCA wrapped

Tagging @cantel, @lbeemste, @jburr

Populates jet trigger configuration in legacy JO by converting MenuSequenceCA and appending to Athena with globals. To avoid conflicts, it was also necessary to wrap the MET menu sequences, in part due to PFAlgorithm_(HLT)ftf naming -- have now made these consistent in order to verify configuration.

FYI @tbold, since I mentioned it, and modified some of your code, this is ultimately how I did the checks to avoid reconfiguring sequences inside appendMenuSequenceCAToAthena. A bit crude but it seems to suffice as an interim solution until the CA config can be used fully. It wasn't possible to use RecoFragmentsPool here because the caching is based on the GaudiConfig2 hash, which differs for each instance of the sequence to be converted.

Another point to be noted: In the MET conversion, a workaround is needed to avoid filling the ComboHypo cache with a GaudiConfig2 instance when the ChainStep constructor calls makeCombo. The problem here is that MET's code builds the whole list of ChainSteps at once, with the MenuSequence(CA) internally, so the minimal code addition has to avoid this behaviour in ChainStep. Otherwise the changes would have to be more invasive. However it'd be better to remove this workaround when the legacy JO can be fully removed.

I have not been able to ensure identical sequence naming in all places. However, all consequential configuration differences have been resolved. N.B. I made a fix to the confTool.py code to permit diffing of HLTJobOptions.json, as the script was previously operating one level too high in the json hierarchy.

The full menu runs with this setup. Unconventional tracking also used parts that overlapped with the jet CA, so I have done a selective migration of just the tracking configuration for that signature.

Jet and MET legacy MenuSequence configurations are not yet removed -- perhaps keep these until the configuration is fully validated.

Incidentally fixes ATR-27997, as there were questionable feature count changes associated with j0_perf chains. As of this MR, j0_perf chains will correctly pass all events and not assign jets as passing features, because a streaming hypo is used.

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 2 files:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Config/MenuComponents.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetChainConfiguration.py

Adding @sutt ,@lidiaz ,@shanisch ,@bernius ,@cantel as watchers

added JetEtmiss Trigger TriggerMenu master review-pending-level-1 labels

CI Result FAILURE (hash f85b516d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67381]

Plenty of concerning messages -- which @jburr might have brought up before?

Py:conf2toConfigurable WARNING The handle ServiceHandle of new-config component PixelConditionsSummaryTool.PixelReadoutManager is jus
t a string InDetDD::PixelReadoutManager/PixelReadoutManager, skipping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING   The handle PrivateToolHandle of new-config component trackSelftf.Extrapolator is just a string , ski
pping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING   The handle PrivateToolHandle of new-config component trackSelftf.TrackSummaryTool is just a string ,
 skipping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING   The handle PrivateToolHandle of new-config component trackSelftf.Extrapolator is just a string , ski
pping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING   The handle PrivateToolHandle of new-config component trackSelftf.TrackSummaryTool is just a string ,
 skipping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING    PrivateToolHandleArray DetectorTools of GeoModelSvc/GeoModelSvc does not have the same named compon
ents
Py:conf2toConfigurable WARNING    Old (conf1) ['AFP_GeoModelTool', 'BeamPipeDetectorTool', 'ForDetEnvelopeTool', 'InDetServMatTool', 
'LArDetectorToolNV', 'MuonDetectorTool', 'PixelDetectorTool', 'SCT_DetectorTool', 'TRT_DetectorTool', 'TileDetectorTool', 'ZDC_DetToo
l'] for GeoModelSvc/GeoModelSvc
Py:conf2toConfigurable WARNING    New (conf2) ['BeamPipeDetectorTool', 'InDetServMatTool', 'LArDetectorToolNV', 'MuonDetectorTool', '
PixelDetectorTool', 'SCT_DetectorTool', 'TRT_DetectorTool', 'TileDetectorTool'] for GeoModelSvc/GeoModelSvc
Py:conf2toConfigurable WARNING    Will try to merge them, but this might go wrong!
Py:conf2toConfigurable WARNING   The handle ServiceHandle of new-config component PixelDistortionAlg.RndmSvc is just a string AthRNGS
vc, skipping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING   The handle ServiceHandle of new-config component InDetTrackingGeometryBuilderCond.EnvelopeDefinition
Svc is just a string AtlasGeometry_EnvelopeDefSvc, skipping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING   The handle ServiceHandle of new-config component CaloTrackingGeometryBuilderCond.EnvelopeDefinitionS
vc is just a string AtlasGeometry_EnvelopeDefSvc, skipping deeper checks, configuration may be incorrect
Py:conf2toConfigurable WARNING The handle ServiceHandle of new-config component HLTCaloCellMaker_FS.TrigDataAccessMT is just a string
 TrigCaloDataAccessSvc/TrigCaloDataAccessSvc, skipping deeper checks, configuration may be incorrect

added 80 commits

• f85b516d...c63572e8 - 77 commits from branch atlas:master
• dff668c9 - Legacy jet slice with MenuSequenceCA wrapped
• ba6deb41 - Remove unused import
• a31eb663 - Fix naming conflict

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 3 files:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Config/MenuComponents.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetChainConfiguration.py
• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Jet/JetTrackingConfig.py

Adding @sutt ,@amorley ,@lidiaz ,@shanisch ,@bernius ,@cantel as watchers

CI Result FAILURE (hash a31eb663)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67388]

marked this merge request as draft

removed review-pending-level-1 label

Moved to draft for now, will deal with next week incl requested change.

added 2 commits

• 083bd9fe - Provide MenuSequenceCA converter that does not call generator function
• 9764ce41 - Configure jet slice in legacy config by wrapping MenuSequenceCA calls

Compare with previous version

mentioned in merge request !61491 (merged)

resolved all threads

changed the description

changed target branch from master to 23.0

removed master label

added 1154 commits

• 9764ce41...2a9a8dda - 1153 commits from branch atlas:23.0
• 2acc313e - Configure jet slice in legacy config by wrapping MenuSequenceCA calls

Compare with previous version

added 1444 commits

• 2acc313e...baac7354 - 1443 commits from branch atlas:23.0
• bfe96d13 - Configure jet slice in legacy config by wrapping MenuSequenceCA calls

Compare with previous version