Use more MagicNumbers header instead of hardcoded values

Use more MagicNumbers header instead of hardcoded values

@jchapman

This merge request affects 10 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/MCTruthClassifier
• PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools
• Simulation/Barcode/BarcodeServices
• Simulation/G4Atlas/G4AtlasTests
• Simulation/G4Sim/MCTruth
• Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen
• Trigger/TrigAnalysis/TrigInDetAnalysisUtils

Affected files list will not be printed in this case

Adding @zmarshal ,@jcatmore ,@calpigia ,@dshope ,@nagano ,@sutt ,@mvozak ,@jveatch ,@amorley ,@jchapman as watchers

added Analysis BTagging Derivation Egamma JetEtmiss Simulation Trigger analysis-review-required master review-pending-level-1 labels

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 1cbdf2bc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 3, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 8
AthAnalysis: number of compilation errors 1, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67419]

added 1 commit

• 212e6cca - OK

Compare with previous version

This merge request affects 10 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/MCTruthClassifier
• PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools
• Simulation/Barcode/BarcodeServices
• Simulation/G4Atlas/G4AtlasTests
• Simulation/G4Sim/MCTruth
• Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen
• Trigger/TrigAnalysis/TrigInDetAnalysisUtils

Affected files list will not be printed in this case

Adding @zmarshal ,@jcatmore ,@calpigia ,@dshope ,@nagano ,@sutt ,@mvozak ,@jveatch ,@amorley ,@jchapman as watchers

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 212e6cca)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 4
AthAnalysis: number of compilation errors 1, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67423]

added 1 commit

• d3792a16 - OK

Compare with previous version

This merge request affects 10 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/MCTruthClassifier
• PhysicsAnalysis/TrackingID/InDetTrackSystematicsTools
• Simulation/Barcode/BarcodeServices
• Simulation/G4Atlas/G4AtlasTests
• Simulation/G4Sim/MCTruth
• Trigger/EFTracking/EFTrackingSim/TrigHTTBankGen
• Trigger/TrigAnalysis/TrigInDetAnalysisUtils

Affected files list will not be printed in this case

Adding @zmarshal ,@jcatmore ,@calpigia ,@dshope ,@nagano ,@sutt ,@mvozak ,@jveatch ,@amorley ,@jchapman as watchers

CI Result SUCCESS (hash d3792a16)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67428]

OK from AR viewpoint, approved

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

merged

mentioned in commit 381d4cc3

added sweep:ignore label