Fix METMap for PHYS -> PHYSLITE production

The MissingETAssociationMap (METmap) is the main blocker for being able to produce PHYSLITE directly from PHYS at the moment - the METmap exists in PHYS, but cannot be directly copied for use in PHYSLITE as PHYSLITE contains calibrated objects, so the existing element links in the map will be invalid.

The proposed solution is to add a new algorithm to produce a corrected METmap by relinking the ElementLinks contained in the map to calibrated objects as appropriate.

added 1 commit

• 82ec7f79 - Fix compile errors

Compare with previous version

added 1 commit

• 16c54013 - More fixes

Compare with previous version

added 1 commit

• bb60cc6b - First working version

Compare with previous version

Hello,

following the creation of the 23.0 branch from master, you should now decide whether this MR should target 23.0 or master, according to these guidelines agreed in the Software Weekly meeting:

https://indico.cern.ch/event/1266042/attachments/2613269/4515725/branching_guidelines.pdf

If you decide that this MR should target 23.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 23.0 will also be swept into master.

Thanks!

James & Nick

added 2 commits

• eaf345e4 - Add framework for retrieving/storing the METMap
• e9d50f00 - Add METMap to output

Compare with previous version

added 1 commit

• 95696d4b - Implement relinking to calibrated jets

Compare with previous version

added 1 commit

• ad926f41 - Update copyrights

Compare with previous version

resolved all threads

changed target branch from master to 23.0

added 1 commit

• faf67c71 - Add MET core container to output

Compare with previous version

added 1 commit

• b50de393 - Implement relinking for the objectLinks vector

Compare with previous version

added 1 commit

• 2b9a2fd1 - Handle removed jets and misc association

Compare with previous version

added 1 commit

• 9b19645c - Update met core container

Compare with previous version

added 1 commit

• 1b21a710 - Simplify procedure

Compare with previous version

Looks like a good first pass. I'd recommend running some tests on this (or having some experts do it) to ensure that the analysis-level output is identical to the AOD->PHYSLITE workflow before merging.

added 1 commit

• f1aa61b4 - Implement suggestions

Compare with previous version

resolved all threads

resolved all threads

added 1 commit

• 6d0e5fe3 - Avoid creating private stores, use handles directly, only call toPersistent as needed

Compare with previous version

What is happening with this MR ? David as L2

added 1 commit

• e55e94b6 - Use setJetLink() instead of setRefJet()

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

Affected files list will not be printed in this case

Adding @zmarshal ,@jmellent ,@jveatch ,@ispokhar ,@jcatmore ,@calpigia ,@dshope ,@mhodgkin ,@nelsonc as watchers

added 23.0 Derivation JetEtmiss labels

resolved all threads

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash e55e94b6)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73485]

added 2 commits

• 40f446c9 - Remove finalize() stub and calls to toPersistent()
• 058633ed - Shift original object accessor declaration to source file

Compare with previous version

added 1 commit

• 06bbb6a8 - Python config changes

Compare with previous version

resolved all threads

marked this merge request as ready

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

Affected files list will not be printed in this case

Adding @zmarshal ,@jmellent ,@emmat ,@jveatch ,@ispokhar ,@jcatmore ,@calpigia ,@dshope ,@mhodgkin ,@nelsonc as watchers

added review-pending-level-1 label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 06bbb6a8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73988]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• f244a005 - Move original object accessor back as (non-static) class member

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

Affected files list will not be printed in this case

Adding @zmarshal ,@jmellent ,@emmat ,@jveatch ,@ispokhar ,@jcatmore ,@calpigia ,@dshope ,@mhodgkin ,@nelsonc as watchers