Updating GenFilterTool for derivations

One of the truth generator filter variables (HT including neutrinos) was missing in release 22. This brings forward the variable definition from release 21.2. At the same time I tried to catch a couple of consistency things within the cxx.

added Derivation changes-derivation-output labels

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth

This merge request affects 2 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth/src/GenFilterTool.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth/src/GenFilterTool.h

Adding @zmarshal ,@jcatmore ,@calpigia as watchers

added master review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 2712aa36)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67568]

Hi Zach, regarding the changes-derivation-output label, should the new decoration be added e.g. here? https://gitlab.cern.ch/atlas/athena/-/blob/master/PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys/python/PHYS.py#L110

Just a few instance of fabs that should be changed to std::abs.

Jason (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• c386f8ce - Fixing more lines of abs

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth

This merge request affects 2 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth/src/GenFilterTool.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth/src/GenFilterTool.h

Adding @zmarshal ,@jcatmore ,@calpigia as watchers

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash c386f8ce)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67588]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• cc4c5553 - Formatting change to case statement

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth

This merge request affects 2 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth/src/GenFilterTool.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth/src/GenFilterTool.h

Adding @zmarshal ,@jcatmore ,@calpigia as watchers

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash cc4c5553)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67669]

Hello @zmarshal, this looks good, but could you please resolve the issues? switching labels to user action requested, --L1

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

Hello @carquin ,

It seems that all threads have been resolved but the MR has still the label review-user-action-required. Are there any further issues that need to be addressed?

Kind regards,

Andrej

I think we can approve the review then --L1

added review-approved label and removed review-user-action-required label

added review-approved-tier0 label

mentioned in commit 45b91f94

merged

added sweep:ignore label

mentioned in merge request !61503 (merged)

mentioned in commit 5549bcec