Improving track reconstruction efficiency for high pT muons

This MR addresses ATLIDTRKCP-434

It includes:

• Pattern recognition changes for ITk: use of pattern covariance (based on cluster width) for all clusters, and using a number of clusters on module <= than the number of allowed clusters per module.
• Seeding changes for ITk: changes in space points grid binning used in seed formation, changes to the seed confirmation, and in the maximum distance between middle and bottom space points.
• Increase in number of surface candidates returned by the SCT_OverlapDescriptor for ITk detector elements.

Additionally, I have rewritten the DiscOverlapDescriptor and updated the configuration of the minimum pT cut for the ITkTrackClusterAssValidation.

Changes are discussed in https://indico.cern.ch/event/1258598/contributions/5286608/attachments/2607062/4503967/UpgradeTracking_230308.pdf

No differences are expected for Run2-3 reconstruction tests, while they are expected for Run-4.

We should keep an eye on CPU increases as well.

@pagessin @lgagnon @tstreble @nstyles @jmasik @dshope

added ITk Tracking Upgrade master labels

assigned to @ncalace

changed the description

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

added InnerDetector review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

144K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

added Run2-DataReco-output-changed Run3-DataReco-output-changed Run4-MCReco-output-changed labels

CI Result FAILURE (hash aa9ff29c)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67618]

added review-user-action-required label and removed review-pending-level-1 label

Looking into differences now.

added 1 commit

• 5f50db4c - fixing error

Compare with previous version

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

144K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

removed Run2-DataReco-output-changed label

removed Run3-DataReco-output-changed label

resolved all threads

CI Result FAILURE (hash 5f50db4c)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67773]

Changes on Run4 tests are expected. Updating digest for Run4 test.

added 176 commits

• 5f50db4c...e722dca7 - 168 commits from branch atlas:master
• 454e19f1 - resoling
• 616b746e - resolving
• 93681469 - resolving
• 6cc96d79 - updating overlap descr, geometry config, seeding, validation tables
• 4b151487 - add if clause for ITk case
• 9847f488 - setting addional surfaces false for pixel
• 5276240c - fixing error
• ff51abb0 - updating digest for Run4 test

Compare with previous version

This merge request affects 5 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk
• Tools/PROCTools

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

added Tools label

WARNING: big files (>100K) are found in the changeset

144K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

CI Result SUCCESS (hash ff51abb0)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67779]

Just a small comment about using changing abs to std::abs --L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 5985c1aa - Using std::abs

Compare with previous version

resolved all threads

removed review-user-action-required label

added review-pending-level-1 label

This merge request affects 5 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk
• Tools/PROCTools

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

WARNING: big files (>100K) are found in the changeset

144K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash 5985c1aa)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68011]

Hi @ncalace, unfortunately this picked up some conflicts --L1

added review-user-action-required label and removed review-pending-level-1 label

added 262 commits

• 5985c1aa...54f05ee8 - 254 commits from branch atlas:master
• 45d0c5c7 - resoling
• bee605d3 - resolving
• f72471b0 - resolving
• 6d67a020 - updating overlap descr, geometry config, seeding, validation tables
• 346cccb9 - add if clause for ITk case
• 21e6eefa - setting addional surfaces false for pixel
• 7246634d - fixing error
• 4af53280 - updating digest for Run4 test

Compare with previous version

removed review-user-action-required label

added review-pending-level-1 label

Rebasing. Waiting for the CI to succeed.

This merge request affects 5 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk
• Tools/PROCTools

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

WARNING: big files (>100K) are found in the changeset

144K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/ITkSiSpacePointsSeedMaker.cxx

CI Result FAILURE (hash 4af53280)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68119]

CI Test fail due to differences in the produced output, if this is ok you have to update the references --L1

RROR    Your change breaks the digest in test q447.
ERROR    Please make sure this has been discussed in the correct meeting (RIG or Simulation) meeting and approved by the relevant experts.
ERROR    The output 'q447_AOD_digest.txt' (>) differs from the reference 'q447_AOD_digest.ref' (<):
         run       event       nTopo   nIdTracks  nTauTracks       nTaus      nMuons       nElec   nTrueElec   nFakeElec       nPhot   nTruePhot   nFakePhot

2,3c2,3
<       242000       60001         604          77           2           2           2           2           0           2           1           0           1
<       242000       60002         407          46          16           4           3           3           0           3           4           3           1
---
>       242000       60001         604          77           4           3           2           2           0           2           1           0           1
>       242000       60002         407          46          19           6           3           3           0           3           4           3           1