Allow for customization of dynamic attribute split-level

added full-integration-tests full-unit-tests labels

requested review from @amete and @mnowak

This is a draft only. For now it downgrades the splitting of the dynamic store, to avoid ElementLinks to be split. But its not yet clear whether that is desired...

Still, I believe at some point its nice to improve over the hardcoded setting.

Tag @amete , @mnowak

Hi Peter - thanks for that implementation! I like it.
I have just one remark - I would make it so that if we merge this MR, at least at first, the split level for dynamic attributes remains the same by default (so 1). Mainly because we never had any complains about that (as far as I am aware). Even the recent problem reported by Serhan was related to the Aux container (the static part), not the dynamic attributes. So I think the smart thing would be not changing it right away. And when we have the configurable option working we can do the testing.
Cheers, Marcin

Hi Marcin, I agree, we will figure out whether ElementLinks should be split first and then make the appropriate changes. Peter

Hi Peter, Marcin,

Let me post this here for others, too.

As mentioned in ATEAM-891, it looks like we really shouldn't split an ElementLink. I did a quick test w/ a PHYSLITE file (same as in the ticket) where we have METAssoc_AnalysisMETAux that's not written as AuxDyn. Splitting this Aux branch at level 1 ends up putting the jetLink in a dedicated branch but doesn't further split it. Reading this in ROOT one gets:

Event = 715141600 - Jet Link Size = 4
  >> Jet Link Index = 0
  >> Jet Link Index = 1
  >> Jet Link Index = 2
  >> Jet Link Index = 18446744073709551615

While if we increase the split level to 99, we get this:

Event = 715141600 - Jet Link Size = 5
  >> Jet Link Index = 0
  >> Jet Link Index = 0
  >> Jet Link Index = 0
  >> Jet Link Index = 0
  >> Jet Link Index = 0

The concerning bit is that there are no errors/warnings/crashes. We simply cannot read the split ElementLink properly in ROOT.

added 204 commits

061c7811...ce8bd538 - 203 commits from branch atlas:master
ed3dee7d - Merge remote-tracking branch 'upstream/master' into AthenaIO_DynSplitLevel

Compare with previous version

added 1 commit

b662ae55 - Fix option setting by using dbH handle, member not yet set.

Compare with previous version

added 1 commit

7726a395 - Setting dynamic aux store for DAOD to be split (level 1) as currently

Compare with previous version

marked this merge request as ready

This merge request affects 4 packages:

Database/APR/RootStorageSvc
Database/AthenaPOOL/AthenaPoolCnvSvc
Database/AthenaPOOL/OutputStreamAthenaPool
Database/AthenaRoot/RootAuxDynIO

Affected files list will not be printed in this case

Adding @gemmeren ,@amete ,@mnowak ,@ssnyder as watchers

added Database master review-pending-level-1 labels

Hi, it looks like we can correctly read split and unsplit top-level ElementLinks in the dynamic aux store. So this MR will leave those at SplitLevel 1, but that can now be configured. (Personally, I may prefer un-split ElementLinks, but that would be a separate follow-up if people agree.) Anyway, marking the MR as ready, so please shout if you object. Peter

added Run2-DataOverlay-output-changed Run2-DataReco-output-changed Run2-MCOverlay-output-changed Run2-MCReco-output-changed Run3-DataReco-output-changed Run3-MCOverlay-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 7726a395)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67964]