Skip to content
Snippets Groups Projects

Provide MenuSequenceCA converter that does not call generator function

Merged Teng Jian Khoo requested to merge khoo/athena:master-MenuSequenceCAToGlobals into 23.0
All threads resolved!

Addressing @fwinkl's request to separate generic functionality from where it is used (I know the request was for a separate commit, but I think the application will take a while yet to be validated, and this might be useful elsewhere).

Splits the menuSequenceCAToGlobalWrapper function into an append function and the wrapper which calls the generator and then appends. Jet config functions tend to return the MenuSequence(CA) in a tuple with other info, so that case can be more neatly handled by a standalone append.

If this is too late and needs to be redirected to 23.0, I will do so when MRs to that branch are opened.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading