Skip to content
Snippets Groups Projects

Fix pseudo tracks in FTAG derivations

Merged Sebastien Rettie requested to merge srettie/athena:master-srettie-fix-pseudo-tracks into 23.0

When running with pseudo tracks a crash is caused by the muon tools. This can be avoided by turning off muons for any non-standard track collection, implemented in this MR.

Tagging @dguest @asciandr

Merge request reports

Pipeline #5275742 passed

Pipeline passed for 4315e644 on srettie:master-srettie-fix-pseudo-tracks

Approval is optional

Merged by Stefan RichterStefan Richter 2 years ago (Mar 17, 2023 1:47pm UTC)

Merge details

  • Changes merged into 23.0 with 33419550 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sebastien Rettie resolved all threads

    resolved all threads

  • added 1 commit

    • 4315e644 - Make override less sneaky/blunt

    Compare with previous version

  • This merge request affects 1 package:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag

    This merge request affects 1 file:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag/python/FtagDerivationConfig.py

    Adding @jcatmore ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@calpigia ,@bdong as watchers

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :x: CI Result FAILURE (hash aba12f89)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68042]

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :x: CI Result FAILURE (hash 4315e644)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68043]

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag

    This merge request affects 1 file:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag/python/FtagDerivationConfig.py

    Adding @jcatmore ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@calpigia ,@bdong as watchers

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 4315e644)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68115]

  • Lgtm, approving --L1

  • Sebastien Rettie changed target branch from master to 23.0

    changed target branch from master to 23.0

  • Sebastien Rettie resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag

    This merge request affects 1 file:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag/python/FtagDerivationConfig.py

    Adding @jcatmore ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@calpigia ,@bdong as watchers

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading