Adding original track decoration for GSF Tracks to PHYSLITE

The decoration connecting the GSF track particle to the original track particle (in a different collection) was missing from PHYSLITE. This caused some issues in overlap removal in rare cases, and potentially other places (unclear about MET). I've checked that the links are there, seem to point to the correct container, and seem to have an index (I hope that's sufficient to indicate that this is working!).

Thanks very much to @mhank for the report!

Discussion: https://indico.cern.ch/event/1264717/contributions/5318949/attachments/2612345/4513767/amg_mh.pdf

Original thread: https://groups.cern.ch/group/atlas-sw-amg/Lists/Archive/Flat.aspx?RootFolder=%2Fgroup%2Fatlas%2Dsw%2Damg%2FLists%2FArchive%2FPotential%20PHYSLITE%20Issue%2D%20ElectronMuon%20OR&FolderCTID=0x012002009E45C4887AC2C0468B02F05418657558

added Derivation changes-derivation-output labels

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

This merge request affects 1 file:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys/python/PHYSLITE.py

Adding @zmarshal ,@jcatmore ,@calpigia ,@dshope as watchers

added master review-pending-level-1 labels

Hi @zmarshal ,

well spotted... but I'm wondering if this will be 100% watertight. I'm assuming this originalTrackParticle is pointing to the InDetTrackParticles (thinned) rather than the GSFTrackParticles (not thinned), and since we don't explicitly keep the InDetTrackParticles associated with electrons (because we instead have the GSF container) I think it will only be by luck (track > 10GeV or shared with a muon or tau etc) that the track will be there.

If we want this link to be valid we'd have to do thinning to keep also the InDetTrackParticles associated with electrons, but I guess we don't want to do that due to size...

Cheers,

James

resolved all threads

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 77d71b61)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68074]

Jenkins please restart a build

Jenkins please retry a build

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

This merge request affects 1 file:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys/python/PHYSLITE.py

Adding @zmarshal ,@jcatmore ,@calpigia ,@dshope as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 77d71b61)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68102]

unrelated failure. lgtm

added review-approved label and removed review-pending-level-1 label

added review-pending-level-1 label and removed review-approved label

Hello,

following the creation of the 23.0 branch from master, you should now decide whether this MR should target 23.0 or master, according to these guidelines agreed in the Software Weekly meeting:

https://indico.cern.ch/event/1266042/attachments/2613269/4515725/branching_guidelines.pdf

If you decide that this MR should target 23.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 23.0 will also be swept into master.

Thanks!

James & Nick

changed target branch from master to 23.0

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

This merge request affects 1 file:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys/python/PHYSLITE.py

Adding @zmarshal ,@jcatmore ,@calpigia ,@dshope as watchers

added 23.0 label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.