Masking SCells when it is data

This MR is meant to solve one problem observed in the prepossessing (ie. ATR-27084) I will set the masking flag for jFEX and gFEX automatically depending on if it is MC or Data.

FYI @dzanzi @tamartin

added Run3L1Calo urgent labels

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 2 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/FEXReprocessingRun3.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py

Adding @thompson ,@serodrig as watchers

added 23.0 Trigger review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash a9cf5d72)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68207]

@serodrig the CI fails because the trigger count reference files need to be updated: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BC7G11AthenaOpt/NICOS_TestLog_MR-61602-2023-03-17-11-05/ReleaseTests___CITest_Trigger_athenaHLT_v1Dev-test__CITest_Trigger_athenaHLT_v1Dev-test__m.html

However, there is a very large drop in rates. Is this OK?

@tamartin @sshaw @astruebi @lidiaz

resolved all threads

added review-approved-point1 label

added 3 commits

• a9cf5d72...1dabd1bb - 2 commits from branch atlas:23.0
• ae379e06 - Masking SCells when it is data

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 2 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/FEXReprocessingRun3.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py

Adding @thompson ,@serodrig as watchers

removed review-approved-point1 label

@serodrig you have not committed the changes to the counts? Is it because you want to get the diff from the CI tests?

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash ae379e06)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68241]

added 1 commit

• 03b8956a - Updating ref.

Compare with previous version

resolved all threads

resolved all threads

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @vmartin ,@martindl ,@salderwe ,@serodrig ,@thompson ,@okumura as watchers

added changes-trigger-counts label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.