Minor fixes for xAODDecaysFinalStateFilter

initialize the correct one included in the filtering sequence

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Generators/GeneratorFilters

This merge request affects 1 file:

• Generators/GeneratorFilters/share/common/xAODDecaysFinalStateFilter_Common.py

added Generators master review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 139f6868)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68304]

Dear @tsulaia,

i would like to use this filter in my JO, like this:

include("GeneratorFilters/xAODDecaysFinalStateFilter_Common.py")
filtSeq.xAODDecaysFinalStateFilter.PDGAllowedParents = [ 23 ]

while the log always give me an error:

AttributeError: 'NoneType' object has no attribute 'PDGAllowedParents'

i guess this could be resulting from the wrong filter name in athena, but it strangely fails ci test,

am i missing something?

Cheers, Yi

Jenkins please retry a build

This merge request affects 1 package:

• Generators/GeneratorFilters

This merge request affects 1 file:

• Generators/GeneratorFilters/share/common/xAODDecaysFinalStateFilter_Common.py

Hi @tsulaia yes, I fully support the fix. Sorry for the mistake in the common fragment and thanks @yiyu for catching it. Cheers, ewelinA

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 139f6868)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68335]

resolved all threads

Hi @yiyu

if the fix is to be used in production - please let me know, because we would need then to build a new release. Thanks, ewelinA

Hi @ewelina,

we would like to use this filter for MC21a ggZllZqq Sherpa sample: https://its.cern.ch/jira/browse/ATLMCPROD-10325

the JO is attached in the Jira, if any further info needed to build a suitable ralease, ping me anytime,

thank you, Yi

Thanks @yiyu for the info. I will build the release when this MR is merged i.e. this or beginning of next week.

Hi @yiyu and @ewelina can you please confirm that this MR has to go into master and not in 23.0? https://indico.cern.ch/event/1266042/attachments/2613269/4515725/branching_guidelines.pdf

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

lgtm

added review-approved label and removed review-user-action-required label

merged

mentioned in commit ba0ec928

added sweep:ignore label