Skip to content
Snippets Groups Projects

Changing how FTF can be run as an offline algorithm for ITk

Merged Elliot Watton requested to merge ewatton/athena:ewatton-ITk-FTFinOfflineConfig into master

Adding new offline ITk tracking flag to enable FTF to run as offline algorithm by replacing SiSPSeededTrackFinder. FTF is already able to run as an offline algorith with Reco_tf via a standalone file, TrigFastTrackFinder/ITkFastTrackFinderStandaloneConfig which is added as a --postInclude option. This was first included with !56436 (merged). Since then, this way of running FTF has been vital for continued development and optimisation, and is also used in the nightly ART tests test_run4_mu100_FTF and test_run4_ttbar_PU200_FTF.

This merge request introduces a new way of running FTF as an offline algorithm in which FTF replaces the offline SiSPSeededTrackMaker in the offline configuration if a new offline ITk tracking flag, ConfigFlags.ITk.Tracking.useFTF, is set to true. This way of running FTF had been suggest multiple times when presenting performance comparisons between offline and FTF as a part of EFTRACK-7.

As this only impacts how FTF is ran with ITk, this merge request targets master.

Tagging @baines @demelian @smh

Edited by Elliot Watton

Merge request reports

Pipeline #5320894 passed

Pipeline passed for 36dc455c on ewatton:ewatton-ITk-FTFinOfflineConfig

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 2 years ago (Mar 24, 2023 10:18am UTC)

Merge details

  • Changes merged into with b41ad3e1.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Jiri Masik
  • Jiri Masik
  • Elliot Watton added 1 commit

    added 1 commit

    • 7a7484e8 - Fixing type mismatch and preventing unwanted change to ITkConfigFlags

    Compare with previous version

  • Elliot Watton added 2 commits

    added 2 commits

    • 6b197724 - Moving FTF config, moving cloneAndReplace, removing uneccessary extension from FTFPass flags
    • 77aae673 - Updating FTF ART tests to work with new way of running FTF

    Compare with previous version

  • Elliot Watton resolved all threads

    resolved all threads

  • Author Developer

    Resolving threads. Please look at each to see the fix/reply.

  • Elliot Watton added 1 commit

    added 1 commit

    • 767f9c5d - Removing forgottern debug statements

    Compare with previous version

  • Author Developer

    Also included changes to config for FTF ART tests in InDetPhysValMonitoring to work with new setup. doFastTracking setup of offline is disabled for the time being.

    Edited by Elliot Watton
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading