Fixing jFEX input data decoder crash.
This MR is meant to fix one crash observed and reported in ATR-27054
The problem was that the Trailers where correctly set, however due to a non-expected word at the end, the algorithm tried to decode the next FPGA. That is was impossible since there are just 4 FPGAs..
The solution was to add one checker to know if there is something to decode, check that at least has two Trailers.
Merge request reports
Activity
added Run3L1Calo label
This merge request affects 1 package:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream
This merge request affects 2 files:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.h
added 23.0 Trigger review-pending-level-1 labels
CI Result SUCCESS (hash 40cad56d)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68702]This merge request affects 1 package:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream
This merge request affects 2 files:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.h
CI Result SUCCESS (hash 40cad56d)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68714]This merge request affects 1 package:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream
This merge request affects 5 files:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/python/L1CaloFEXByteStreamConfig.py
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.h
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexRoiByteStreamTool.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexRoiByteStreamTool.h
added 80 commits
-
40cad56d...7963a4c0 - 78 commits from branch
atlas:23.0
- 3bcd069d - Adding the corresponding warning when there is not enough data words
- cf8e6bf2 - Adding the corresponding warning when there is not enough data words
-
40cad56d...7963a4c0 - 78 commits from branch
This merge request affects 1 package:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream
This merge request affects 2 files:
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.cxx
- Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream/src/jFexInputByteStreamTool.h
CI Result SUCCESS (hash c3c79c06)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68750] CI Result SUCCESS (hash cf8e6bf2)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68756]added review-approved label and removed review-pending-level-1 label