Migrate ALFA and AFP sequences to CA

This MR migrates ALFA and AFP menu sequences to CA.

• ALFAPerfSequence
• AFPTrkSequence
• AFPTrkRecoHypoSequence → obsolete, removed
• AFPGlobalSequence

Tested with test_trig_data_v1lowMu_build. Config diff shows some differences, but they are mostly due to naming, e.g.:

 Component  AFPGlobalFS  only in 2nd file


 Component AFPGlobalRecoSeq only in 1st file

Component AFPGlobalSequence may differ
        Members =  ['InputMakerForRoI/IM_AFPGlobalFS', 'AthSequencer/AFPGlobalRecoSeq']  vs  ['InputMakerForRoI/IMAFPGlobalFS', 'AthSequencer/AFPGlobalFS']   <<
                >>  only in 1st file :  ['AthSequencer/AFPGlobalRecoSeq', 'InputMakerForRoI/IM_AFPGlobalFS']
                >>  only in 2nd file :   ['InputMakerForRoI/IMAFPGlobalFS', 'AthSequencer/AFPGlobalFS']
                >>  :  InputMakerForRoI/IM_AFPGlobalFS  vs  InputMakerForRoI/IMAFPGlobalFS  << at index 0
                >>  :  AthSequencer/AFPGlobalRecoSeq  vs  AthSequencer/AFPGlobalFS  << at index 1
        ModeOR = False  only in 1st file
   3 relevant differences

However it seems that all configured algorithms work properly from looking debug athena logs and rootcomp.py output:

$ rootcomp.py test_init/expert-monitoring.root test_final/expert-monitoring.root
[...]

Summary:
========
Total histograms compared: 2140
Missing references: 0
Matching histograms: 2140
Different histograms: 0
Ignored histograms: 141

CC: @tbold

Trigger/TriggerCommon/TriggerMenuMT/python/HLT/MinBias/AFPMenuSequence.py

-# 
+#
 #  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
 #
-from TriggerMenuMT.HLT.Config.MenuComponents import MenuSequence,algorithmCAToGlobalWrapper
-from AthenaCommon.CFElements import parOR, seqAND
+
+from AthenaConfiguration.AccumulatorCache import AccumulatorCache
+from AthenaConfiguration.ComponentAccumulator import ComponentAccumulator
 from AthenaConfiguration.ComponentAccumulator import conf2toConfigurable
 from AthenaConfiguration.ComponentFactory import CompFactory
-from DecisionHandling.DecisionHandlingConf import InputMakerForRoI, ViewCreatorInitialROITool
-from TriggerMenuMT.HLT.Config.MenuComponents import RecoFragmentsPool
+from TriggerMenuMT.HLT.Config.MenuComponents import InEventRecoCA, SelectionCA, MenuSequenceCA
 
 
-def AFPTrkRecoBaseSequence(flags):
-    # Create inputs using input maker
-    AFPInputMaker = InputMakerForRoI("IM_AFPTrackingFS")
-    AFPInputMaker.RoITool = ViewCreatorInitialROITool()
-    AFPInputMaker.RoIs = "AFPRoIs"
+@AccumulatorCache
+def AFPTrkRecoBaseSequenceCA(flags):
+    recoAcc = InEventRecoCA(name='AFPTrackingFS')
 
     from AthenaCommon.GlobalFlags import globalflags
-
     if globalflags.InputFormat.is_bytestream():
-        # bytestream convertor
-        AFP_Raw=CompFactory.AFP_RawDataProvider("AFP_RawDataProvider")
+        acc = ComponentAccumulator()
 
-        # digitalization
-        AFP_R2D=CompFactory.AFP_Raw2Digi("AFP_Raw2Digi")
+        # Bytestream converter
+        AFP_Raw = CompFactory.AFP_RawDataProvider("AFP_RawDataProvider")
+        acc.addEventAlgo(AFP_Raw)
 
-    #cluster reconstruction
+        # Digitalization
+        AFP_R2D = CompFactory.AFP_Raw2Digi("AFP_Raw2Digi")
+        acc.addEventAlgo(AFP_R2D)
 
-    from AFP_SiClusterTools.AFP_SiClusterTools import AFP_SiClusterTools_HLT
-    AFP_SiCl= algorithmCAToGlobalWrapper(AFP_SiClusterTools_HLT,flags)
-    
-    # tracks reconstruction
-    from AFP_LocReco.AFP_LocReco import AFP_LocReco_SiD_HLT
-    AFP_SID = algorithmCAToGlobalWrapper(AFP_LocReco_SiD_HLT,flags)
-    
-    if globalflags.InputFormat.is_bytestream():
-        AFPRecoSeq = parOR("AFPTrkRecoSeq", [AFP_Raw, AFP_R2D, AFP_SiCl, AFP_SID])
-    else:
-        AFPRecoSeq = parOR("AFPTrkRecoSeq", [AFP_SiCl, AFP_SID])
-    
-    return (AFPRecoSeq, AFPInputMaker)
+        recoAcc.mergeReco(acc)
 
+    # Cluster reconstruction
+    from AFP_SiClusterTools.AFP_SiClusterTools import AFP_SiClusterTools_HLT
+    AFP_SiCl = AFP_SiClusterTools_HLT(flags)
+    recoAcc.mergeReco(AFP_SiCl)
 
-def AFPTrkSequenceCfg(flags):
+    # Tracks reconstruction
+    from AFP_LocReco.AFP_LocReco import AFP_LocReco_SiD_HLT
+    AFP_SID = AFP_LocReco_SiD_HLT(flags)
+    recoAcc.mergeReco(AFP_SID)
 
-    # Retrieve input maker and reco seq
-    (recoSeq, inputMaker) = RecoFragmentsPool.retrieve(AFPTrkRecoBaseSequence, flags)
-    AFPPassThroughSequence = seqAND("AFPPassThroughSequence", [inputMaker, recoSeq])
+    return recoAcc
 
-    hypoAlg = conf2toConfigurable(CompFactory.TrigStreamerHypoAlg("AFPPassThroughHypo"))
 
-    def trigStreamerAFPHypoTool(chain_dict):
-        return conf2toConfigurable(CompFactory.TrigStreamerHypoTool(chain_dict["chainName"]))
+@AccumulatorCache
+def AFPTrkSequence(flags):
+    def trigStreamerAFPHypoTool(chainDict):
+        return conf2toConfigurable(CompFactory.TrigStreamerHypoTool(chainDict['chainName']))
 
-    return MenuSequence(flags,
-                        Sequence = AFPPassThroughSequence,
-                        Maker    = inputMaker,
-                        Hypo     = hypoAlg,
-                        HypoToolGen = trigStreamerAFPHypoTool)
+    recoAcc = AFPTrkRecoBaseSequenceCA(flags)
 
-def TestTrigAFPDijetHypoToolGen(flags, chainDict):
-    from TrigAFPHypo.TrigAFPHypoConf import TestTrigAFPDijetHypoTool
-    hypo = TestTrigAFPDijetHypoTool(chainDict["chainName"])
+    hypo = CompFactory.TrigStreamerHypoAlg('AFPPassThroughHypo')
 
-    from AthenaMonitoringKernel.GenericMonitoringTool import GenericMonitoringTool
-    monTool = GenericMonitoringTool(flags, "MonTool_AFP_Hypo")
-    monTool.defineHistogram('DijetMass', type='TH1F', path='EXPERT', title="Dijet mass", xbins=100, xmin=0, xmax=2000)
-    monTool.defineHistogram('DijetRapidity', type='TH1F', path='EXPERT', title="Dijet rapidity", xbins=100, xmin=-5, xmax=5)
+    selAcc = SelectionCA('AFPPassThroughSequence')
+    selAcc.mergeReco(recoAcc)
+    selAcc.addHypoAlgo(hypo)
 
-    monTool.defineHistogram('XiJet1', type='TH1F', path='EXPERT', title="Jet 1 xi", xbins=100, xmin=0, xmax=1)
-    monTool.defineHistogram('XiJet2', type='TH1F', path='EXPERT', title="Jet 2 x1", xbins=100, xmin=0, xmax=1)
-
-    monTool.defineHistogram('PredictProtonAEnergy', type='TH1F', path='EXPERT', title="Predicted proton energy A", xbins=100, xmin=0, xmax=10000)
-    monTool.defineHistogram('PredictProtonCEnergy', type='TH1F', path='EXPERT', title="Predicted proton energy C", xbins=100, xmin=0, xmax=10000)
-
-    monTool.defineHistogram('SideA_predictX', type='TH1F', path='EXPERT', title="Predicted X side A", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('SideA_predictY', type='TH1F', path='EXPERT', title="Predicted Y side A", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('SideC_predictX', type='TH1F', path='EXPERT', title="Predicted X side C", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('SideC_predictY', type='TH1F', path='EXPERT', title="Predicted Y side C", xbins=100, xmin=-100, xmax=100)
-
-    monTool.defineHistogram('XDiff', type='TH1F', path='EXPERT', title="X difference", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('YDiff', type='TH1F', path='EXPERT', title="Y difference", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('distance', type='TH1F', path='EXPERT', title="distance", xbins=100, xmin=0, xmax=50)
-    
-    monTool.defineHistogram('SideA_trackX', type='TH1F', path='EXPERT', title="Track X side A", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('SideA_trackY', type='TH1F', path='EXPERT', title="Track Y side A", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('SideA_diffX', type='TH1F', path='EXPERT', title="Track X diff side A", xbins=100, xmin=-50, xmax=50)
-    monTool.defineHistogram('SideA_diffY', type='TH1F', path='EXPERT', title="Track Y diff side A", xbins=100, xmin=-50, xmax=50)
-    
-    monTool.defineHistogram('SideC_trackX', type='TH1F', path='EXPERT', title="Track X side C", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('SideC_trackY', type='TH1F', path='EXPERT', title="Track Y side C", xbins=100, xmin=-100, xmax=100)
-    monTool.defineHistogram('SideC_diffX', type='TH1F', path='EXPERT', title="Track X diff side C", xbins=100, xmin=-50, xmax=50)
-    monTool.defineHistogram('SideC_diffY', type='TH1F', path='EXPERT', title="Track Y diff side C", xbins=100, xmin=-50, xmax=50)
-    
-    #monToolHypo.HistPath = 'AFPComboHypo/'+tool.getName()
-    hypo.MonTool = monTool
+    return MenuSequenceCA(flags, selAcc, HypoToolGen=trigStreamerAFPHypoTool)
 
-    return hypo
 
 def TrigAFPDijetComboHypoToolCfg(flags, chainDict):
     from TrigAFPHypo.TrigAFPHypoConf import TrigAFPDijetComboHypoTool
     name = chainDict['chainName']
     tool = TrigAFPDijetComboHypoTool(name)
-    
+
     from AthenaMonitoringKernel.GenericMonitoringTool import GenericMonitoringTool
-    monTool = GenericMonitoringTool(flags, "MonTool_"+name,
-                                    HistPath = 'AFPComboHypo/'+tool.getName())
+    monTool = GenericMonitoringTool(flags, 'MonTool_' + name, HistPath='AFPComboHypo/' + tool.getName())
     monTool.defineHistogram('DijetMass', type='TH1F', path='EXPERT', title="Dijet mass", xbins=100, xmin=0, xmax=2000)
     monTool.defineHistogram('DijetRapidity', type='TH1F', path='EXPERT', title="Dijet rapidity", xbins=100, xmin=-5, xmax=5)
 
@@ -134,66 +92,62 @@ def TrigAFPDijetComboHypoToolCfg(flags, chainDict):
     monTool.defineHistogram('SideC_diffY', type='TH1F', path='EXPERT', title="Track Y diff side C", xbins=100, xmin=-50, xmax=50)
 
     tool.MonTool = monTool
-    return tool
 
+    return tool
 
-def AFPTrkRecoHypoSequence(flags):
-
-    (AFPRecoSeqHypo, AFPInputMakerHypo) = RecoFragmentsPool.retrieve(AFPTrkRecoBaseSequence,flags)
-    AFPSequenceHypo = seqAND("AFPSequenceHypo", [AFPInputMakerHypo, AFPRecoSeqHypo])
-    
-    # Hypo
-    from TrigAFPHypo.TrigAFPHypoConf import TestTrigAFPDijetHypoAlg
-    hypoAlg = TestTrigAFPDijetHypoAlg("TestTrigAFPDijetHypoAlg",
-                                   AFPTrackContainer = 'HLT_AFPTrackContainer',
-                                   InputJetCollection = 'HLT_AntiKt4EMTopoJets_nojcalib')
-    
-
-    return MenuSequence(flags,
-                        Sequence = AFPSequenceHypo,
-                        Maker    = AFPInputMakerHypo,
-                        Hypo     = hypoAlg,
-                        HypoToolGen = TestTrigAFPDijetHypoToolGen)
 
-def AFPGlobalRecoSequence(flags):
+@AccumulatorCache
+def AFPGlobalRecoSequenceCA(flags):
+    recoAcc = InEventRecoCA(name='AFPGlobalFS')
 
-    # Create inputs using input maker
-    AFPInputMaker = InputMakerForRoI("IM_AFPGlobalFS")
-    AFPInputMaker.RoITool = ViewCreatorInitialROITool()
-    AFPInputMaker.RoIs = "AFPGlobalRoIs"
+    # ToF Tracks reconstruction
     from AFP_LocReco.AFP_LocReco import AFP_LocReco_TD_HLT
-    AFP_TD  = algorithmCAToGlobalWrapper( AFP_LocReco_TD_HLT, flags)
+    AFP_TD = AFP_LocReco_TD_HLT(flags)
+    recoAcc.mergeReco(AFP_TD)
 
-    # protons reconstruction
+    # Protons reconstruction
     from AFP_GlobReco.AFP_GlobReco import AFP_GlobReco_HLT
-    AFP_Pr= algorithmCAToGlobalWrapper(AFP_GlobReco_HLT, flags)
-  
-    # vertex reconstruction
-    from AFP_VertexReco.AFP_VertexReco import AFP_VertexReco_HLT
-    AFP_Vtx=algorithmCAToGlobalWrapper(AFP_VertexReco_HLT, flags)
-    AFPRecoSeq = parOR("AFPGlobalRecoSeq", [AFP_TD, AFP_Pr, AFP_Vtx])
-
-    return (AFPRecoSeq, AFPInputMaker)
+    AFP_Pr = AFP_GlobReco_HLT(flags)
+    recoAcc.mergeReco(AFP_Pr)
 
+    # Vertex reconstruction
+    from AFP_VertexReco.AFP_VertexReco import AFP_VertexReco_HLT
+    AFP_Vtx = AFP_VertexReco_HLT(flags)
+    recoAcc.mergeReco(AFP_Vtx)
 
-def AFPGlobalSequenceCfg(flags):
-    recoSeq, inputMaker = RecoFragmentsPool.retrieve(AFPGlobalRecoSequence,flags)
+    return recoAcc
 
-    seq = seqAND("AFPGlobalSequence", [inputMaker, recoSeq])
 
+@AccumulatorCache
+def AFPGlobalSequence(flags):
     def AFPTOFHypoToolGen(chain_dict):
         from TrigAFPHypo.TrigAFPHypoConf import TrigAFPToFHypoTool
-        hypoTool = TrigAFPToFHypoTool(chain_dict["chainName"])
-        return hypoTool
-
-    # HypoAlg
-    from TrigAFPHypo.TrigAFPHypoConf import TrigAFPToFHypoAlg
-    hypoAlg = TrigAFPToFHypoAlg("TrigAFPToFHypoAlg",
-                                      AFPVertexContainer = 'HLT_AFPVertexContainer',
-                                      VertexContainer = 'HLT_IDVertex_FS')
-        
-    return MenuSequence(flags,
-                        Sequence = seq,
-                        Maker    = inputMaker,
-                        Hypo     = hypoAlg,
-                        HypoToolGen = AFPTOFHypoToolGen)
+        return TrigAFPToFHypoTool(chain_dict['chainName'])
+
+    recoAcc = AFPGlobalRecoSequenceCA(flags)
+
+    hypo = CompFactory.TrigAFPToFHypoAlg('TrigAFPToFHypoAlg', AFPVertexContainer='HLT_AFPVertexContainer', VertexContainer='HLT_IDVertex_FS')
+
+    selAcc = SelectionCA('AFPGlobalSequence')
+    selAcc.mergeReco(recoAcc)
+    selAcc.addHypoAlgo(hypo)
+
+    return MenuSequenceCA(flags, selAcc, HypoToolGen=AFPTOFHypoToolGen)
+
+
+if __name__ == '__main__':
+    from AthenaConfiguration.AllConfigFlags import initConfigFlags
+    from AthenaConfiguration.TestDefaults import defaultTestFiles
+    flags = initConfigFlags()
+    flags.Input.Files = defaultTestFiles.AOD_RUN3_MC
+    flags.lock()
+
+    from TriggerMenuMT.HLT.Config.MenuComponents import menuSequenceCAToGlobalWrapper
+
+    afp_trk = AFPTrkSequence(flags)
+    afp_trk.ca.printConfig(withDetails=True)
+    afp_trk_gw = menuSequenceCAToGlobalWrapper(AFPTrkSequence, flags)
+
+    afp_glob = AFPGlobalSequence(flags)
+    afp_glob.ca.printConfig(withDetails=True)
+    afp_glob_gw = menuSequenceCAToGlobalWrapper(AFPGlobalSequence, flags)