Skip to content
Snippets Groups Projects

RNTuple fixes - writing dynamic attribs and setting compression

Merged Marcin Nowak requested to merge mnowak/athena:fix.rntuple.auxdyn.writing into master
All threads resolved!

2 fixes for RNTuple format: 1 - the compression will be set to match the one of the hosting TFile (before it was always set to the default 101) 2 - dynamic attributes will be actually written out now (the detection of AuxStore in the collection was not working right)

Should not affect TTree format at all.

Edited by Marcin Nowak

Merge request reports

Pipeline #5352773 passed

Pipeline passed for 3eaf40a0 on mnowak:fix.rntuple.auxdyn.writing

Merged by Tadej NovakTadej Novak 2 years ago (Mar 31, 2023 7:32am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni
  • added review-approved label and removed review-pending-level-1 label

  • @cvarni, do you want this approved or not? :blush:

  • sorry... miss-clicked the label and didn't notice

  • Marcin Nowak added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • Database/APR/RootStorageSvc
    • Database/AthenaRoot/RootAuxDynIO

    Affected files list will not be printed in this case

    Adding @gemmeren ,@amete ,@mnowak ,@ssnyder as watchers

  • Marcin Nowak resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 3eaf40a0)

    Athena AthSimulation AthGeneration AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68959]

  • The changes look okay and there are no CI issues. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • Tadej Novak mentioned in commit b99bdbd7

    mentioned in commit b99bdbd7

  • merged

  • Scott Snyder mentioned in merge request !61986 (merged)

    mentioned in merge request !61986 (merged)

  • Marcin Nowak mentioned in merge request !62070 (merged)

    mentioned in merge request !62070 (merged)

  • Marcin Nowak mentioned in commit 79382a9e

    mentioned in commit 79382a9e

  • Please register or sign in to reply
    Loading