Skip to content
Snippets Groups Projects

Draft: Test Di-Photon L1Topo Chains for Reprocessing

Closed Marco Montella requested to merge mmontell/athena:Menu_eFEX_Topo into 23.0
1 unresolved thread

This MR tracks the implementation of the following di-EM L1 Topo chains:

0INVM70-0DPHI12-eEM9sl1-eEM9sl6   --> DPHI12-M70-2eEM9L
0INVM70-0DPHI12-eEM12sm1-eEM12sm6 --> DPHI12-M70-2eEM12L

0INVM70-2DR15-eEM9sl1-eEM9sl6   --> 2DR15-M70-2eEM9L
0INVM70-2DR15-eEM12sl1-eEM12sl6 --> 2DR15-M70-2eEM12L

Due to unforeseen difficulties in adding more eEM thresholds we are postponing the implementation of the same algorithms on 2eEM9/12M.

Which are threshold variations on the existing DPHI-M70-2eEMXX items created from the InvariantMassDeltaPhiInclusive2 algorithm.

Tagging @khoo

Edited by Marco Montella

Merge request reports

Pipeline #5741004 failed

Pipeline failed for 3b35b221 on mmontell:Menu_eFEX_Topo

Approval is optional

Closed by Marco MontellaMarco Montella 1 year ago (Jun 20, 2023 9:51am UTC)

Merge details

  • The changes were not merged into 23.0.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Montella added 1 commit

    added 1 commit

    • 5c65bc0e - Fixed Multiplicity issues for eEM9M and eEM12M

    Compare with previous version

  • Marco Montella resolved all threads

    resolved all threads

  • Marco Montella added 1 commit

    added 1 commit

    Compare with previous version

  • Marco Montella marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@ademaria ,@salderwe ,@ggonella ,@vmartin ,@okumura ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

    :pencil: 228K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 392K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    :pencil: 156K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

  • Teng Jian Khoo
  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash c962b3d6)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69394]

  • Marco Montella added 1 commit

    added 1 commit

    • 0839c2b2 - eEMSPAREs now onl replaced in MC menu

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@ademaria ,@salderwe ,@ggonella ,@vmartin ,@okumura ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

    :pencil: 228K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 392K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    :pencil: 156K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

  • Marco Montella resolved all threads

    resolved all threads

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :x: CI Result FAILURE (hash 0839c2b2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69395]

  • Marco Montella added 1 commit

    added 1 commit

    • bd6e0339 - Restoring spare thresholds in TopoAlgoDefMultiplicity

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@ademaria ,@salderwe ,@ggonella ,@vmartin ,@okumura ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

    :pencil: 228K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 392K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    :pencil: 156K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :x: CI Result FAILURE (hash bd6e0339)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69400]

  • Hi @mmontell. Several CI tests are failing with the same error: "ERROR Algorithm of name Mult_eEM9M in category multiplicity topo is not registered."

    Can you look into it?

    -- James from L1

  • Marco Montella added 1 commit

    added 1 commit

    • 34e415da - Exploring solution for TopoAlgoDef

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@ademaria ,@salderwe ,@ggonella ,@vmartin ,@okumura ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

    :pencil: 240K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 412K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    :pencil: 156K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

  • Marco Montella marked this merge request as draft

    marked this merge request as draft

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :x: CI Result FAILURE (hash 34e415da)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69973]

  • Marco Montella added 1 commit

    added 1 commit

    • bc21a684 - Restored eEM SPARE thresholds in TopoAlgoDefMultiplicity

    Compare with previous version

  • Marco Montella added 1 commit

    added 1 commit

    • 9702ba0b - Removing DiPhoton topos on eEM9M and eEM12MÂ, moving to L inputs

    Compare with previous version

  • Marco Montella added 1 commit

    added 1 commit

    Compare with previous version

  • Marco Montella changed the description

    changed the description

  • 163 163 # Photon chains for TLA
    164 164 ChainProp(name='HLT_g35_loose_PhysicsTLA_L1EM22VHI',stream=['TLA'], groups=SinglePhotonGroup+DevGroup),
    165 165
    166 # Photons for diPhoton TLA
    167 # M, DPHI
    168 ChainProp(name='HLT_2g10_loose_PhysicsTLA_L1DPHI12-M70-2eEM9L',l1SeedThresholds=['eEM9'],stream=['TLA'], groups=SupportPhIGroup+Topo2Group+DevGroup),
    169 ChainProp(name='HLT_2g10_medium_PhysicsTLA_L1DPHI12-M70-2eEM9L',l1SeedThresholds=['eEM9'],stream=['TLA'], groups=SupportPhIGroup+Topo2Group+DevGroup),
    170 ChainProp(name='HLT_2g13_loose_PhysicsTLA_L1DPHI12-M70-2eEM12L',l1SeedThresholds=['eEM12L'],stream=['TLA'], groups=SupportPhIGroup+Topo2Group+DevGroup),
    • Author Developer

      @khoo How bad is it to have eEM9 as l1SeedThreshold for the eEM9L and eEM12L (not the L) for the 2eEM12 chains?

      This is because eEM9L apparently doesn't exist as HLT-l1SeedThreshold, nor does eEM12 plain.

      Edited by Marco Montella
    • Ok this is sort of interesting/subtle. L1Topo builds the input lists via a defined set of algs. These needn't correspond to the thresholds that are counted by the multiplicity algs.

      In particular the loose eEM input list is defined here: https://gitlab.cern.ch/atlas/athena/-/blob/23.0/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py#L80 It doesn't have to reference a concrete threshold. Same for the eEM12. The et threshold is determined in the topo algorithm.

      Tbh this isn't something I was consciously aware of until you brought it up... But it is apparent (though arguably obscurely so) from TopoAlgoDef.

      For HLT seeding, the 'only' drawback is some extra HLT CPU needed to start the reconstruction on the looser thresholds. There should be no technical problem.

    • Please register or sign in to reply
  • Author Developer

    Jenkins please retry a build

  • Marco Montella added 2063 commits

    added 2063 commits

    • 8444d6e3...5d0827d8 - 2048 commits from branch atlas:23.0
    • 8d19bac4 - Implementation of additional eFEX L1 Topo under the INVM_DPHI_eEMsl6 algorithm + chains in Dev Menu
    • 3f94ac03 - Implementation of additional eFEX L1 Topo under the INVM_DPHI_eEMsl6 algorithm + chains in Dev Menu
    • ee09c94d - Moving new items to MC menu
    • 1ae91e14 - Added boosted diPhoton L1s to MC menu
    • 9b2e83dc - Adding Additional eEM-M thresholds + DR+M di-eEM L1Topo Algo
    • 7f90b9f5 - Trying to correctly define the new L1 algos in the MC Menus
    • 349a65d4 - Fixed Multiplicity issues for eEM9M and eEM12M
    • 59e42ab7 - Updated references
    • aafef408 - eEMSPAREs now onl replaced in MC menu
    • c479e6ec - Restoring spare thresholds in TopoAlgoDefMultiplicity
    • c8b4eb5f - Exploring solution for TopoAlgoDef
    • 1f9c4934 - Restored eEM SPARE thresholds in TopoAlgoDefMultiplicity
    • 4e77620b - Removing DiPhoton topos on eEM9M and eEM12MÂ, moving to L inputs
    • ee565832 - Cleanup
    • 4fe0f7b3 - Trying to merge things

    Compare with previous version

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@ademaria ,@salderwe ,@ggonella ,@vmartin ,@okumura ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

    :pencil: 280K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 488K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    :pencil: 160K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :x: CI Result FAILURE (hash 4fe0f7b3)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72276]

  • Marco Montella added 349 commits

    added 349 commits

    • 4fe0f7b3...b8c9690f - 320 commits from branch atlas:23.0
    • b8c9690f...e8fdea7a - 19 earlier commits
    • 33e81e14 - Trying to correctly define the new L1 algos in the MC Menus
    • 8023ee97 - Fixed Multiplicity issues for eEM9M and eEM12M
    • 8279dfb6 - Updated references
    • 0b591503 - eEMSPAREs now onl replaced in MC menu
    • 2e5dbf56 - Restoring spare thresholds in TopoAlgoDefMultiplicity
    • c5c24603 - Exploring solution for TopoAlgoDef
    • e5ac78e0 - Restored eEM SPARE thresholds in TopoAlgoDefMultiplicity
    • d4de8ed5 - Removing DiPhoton topos on eEM9M and eEM12MÂ, moving to L inputs
    • 23349986 - Cleanup
    • aa137306 - Fixing conflicts pre-merge

    Compare with previous version

  • Marco Montella added 1 commit

    added 1 commit

    Compare with previous version

  • Marco Montella added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@ademaria ,@salderwe ,@ggonella ,@vmartin ,@okumura ,@carquin ,@iriu ,@malconad ,@shanisch ,@gipezzul ,@lidiaz as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

    :pencil: 280K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 492K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    :pencil: 160K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :x: CI Result FAILURE (hash 3b35b221)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72823]

  • closed

  • Please register or sign in to reply
    Loading