AsgTool improvements

fix for getProperty method in latest Gaudi/athena, and improvement for checking empty status of AnaToolHandle

These are low-level improvements pulled out of !61546 (merged) in order to get them into the nightly ASAP.

This merge request affects 1 package:

• Control/AthToolSupport/AsgTools

This merge request affects 2 files:

• Control/AthToolSupport/AsgTools/AsgTools/AnaToolHandle.icc
• Control/AthToolSupport/AsgTools/AsgTools/AsgTool.icc

Adding @krumnack ,@ssnyder as watchers

added Core analysis-review-required master review-pending-level-1 labels

CI Result SUCCESS (hash 5dfc346e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68997]

mentioned in merge request !61546 (merged)

added full-unit-tests label

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthToolSupport/AsgTools

This merge request affects 2 files:

• Control/AthToolSupport/AsgTools/AsgTools/AnaToolHandle.icc
• Control/AthToolSupport/AsgTools/AsgTools/AsgTool.icc

Adding @krumnack ,@ssnyder as watchers

Now that I'm thinking, this should probably go to 23.0, but let's let the CI run first.

CI Result FAILURE (hash 5dfc346e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69017]

Moving to review-user-action-required while there are unresolved threads and CI issues.

Jason (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 8e146521 - updated UT test results

Compare with previous version

This merge request affects 2 packages:

• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/SUSYPhys/SUSYTools

Affected files list will not be printed in this case

Adding @zmarshal ,@salderwe ,@cmerlass ,@cohm ,@krumnack ,@szambito ,@mrimoldi ,@janders ,@miholzbo ,@ssnyder as watchers

added Analysis SUSYTools review-pending-level-1 labels and removed review-user-action-required label

added 1 commit

• 58d1f4c7 - suggested update from MR to avoid using Gaudi::Detail

Compare with previous version

This merge request affects 2 packages:

• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/SUSYPhys/SUSYTools

Affected files list will not be printed in this case

Adding @zmarshal ,@salderwe ,@cmerlass ,@cohm ,@krumnack ,@szambito ,@mrimoldi ,@janders ,@miholzbo ,@ssnyder as watchers

CI Result FAILURE (hash 58d1f4c7)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69074]

CI Result FAILURE (hash 8e146521)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69056]

Hi @will the CI complains with:

Traceback (most recent call last):
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/AthenaCommon/runbatch.py", line 11, in <module>
    theApp.run()     # runs until theApp.EvtMax events reached
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaCommon/AppMgr.py", line 705, in run
    sc = executeRunMethod(nEvt)
cppyy.gbl.SG.ExcNoAuxStore: StatusCode IEventProcessor::executeRun(int maxevt) =>
    ExcNoAuxStore: SG::ExcNoAuxStore: Requested aux data item `::anInt1' (306) but there is no associated aux data store.
Py:Athena            INFO leaving with code 64: "exception raised during an algorithm execute"
ApplicationMgr       INFO Application Manager Finalized successfully
ApplicationMgr       INFO Application Manager Terminated successfully
Traceback (most recent call last):
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/AthenaCommon/runbatch.py", line 11, in <module>
    theApp.run()     # runs until theApp.EvtMax events reached
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaCommon/AppMgr.py", line 705, in run
    sc = executeRunMethod(nEvt)
cppyy.gbl.SG.ExcNoAuxStore: StatusCode IEventProcessor::executeRun(int maxevt) =>
    ExcNoAuxStore: SG::ExcNoAuxStore: Requested aux data item `::anInt1' (306) but there is no associated aux data store.