Use DataPool for TRT_LoLumRawDataContainerCnv

In a heapTrack run of 100 ttbar events

one can see

 5 MOST CALLS TO ALLOCATION FUNCTIONS                                              
     6 21494650 calls to allocation functions with 7.66M peak consumption from         
     7 TRT_LoLumRawDataContainerCnv_p3::persToTrans(InDetRawDataContainer_p3 const*, InDetRawDataContainer<>*, MsgStream&)
     8   at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetEventCnv/InDetEventAthenaPool/src/TRT_LoLumRawDataContainerCnv_p3.cxx:208
     9   in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-03-31T2101/Athena/23.0.23/InstallArea/x86_64-centos7-gcc11-opt/lib/libInDetEventAthenaPool.so

The idea here is to use a DataPool to avoid doing order of 200k small allocation per event

ping @ssnyder and @jchapman

This merge request affects 2 packages:

• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetRawEvent/InDetRawData

Affected files list will not be printed in this case

Adding @cgrefe ,@calfayan ,@gemmeren ,@sroe ,@goetz as watchers

added 23.0 InnerDetector review-pending-level-1 labels

marked this merge request as draft

Hey @ssnyder please take a look I know already that the leakCheck will fail , but not sure

• if I messed something (naively I removed a new and use nextElementPtr)
• if LeakCheck.h understands the pool. As If I understand there is no "free" per se) so there is not 100% match on new/delete in the "classic" definition ?
• or the test needs something in addition to handle the fact that a pool allocator is used

See for example CaloTPCnv/test/CaloClusterContainerCnv_test.cxx.

There, i take care to reference a DataPool before using Leakcheck.

CI Result FAILURE (hash f556156b)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69248]

added 1 commit

• c4e72fb5 - Make the leakCheck work with DataPool

Compare with previous version

Thanks @ssnyder this should do it.

marked this merge request as ready

This merge request affects 2 packages:

• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetRawEvent/InDetRawData

Affected files list will not be printed in this case

Adding @cgrefe ,@calfayan ,@gemmeren ,@sroe ,@goetz as watchers

CI Result SUCCESS (hash c4e72fb5)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69252]

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• 89f32860 - comments

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetRawEvent/InDetRawData

Affected files list will not be printed in this case

Adding @cgrefe ,@calfayan ,@gemmeren ,@sroe ,@goetz as watchers

added review-pending-level-1 label and removed review-user-action-required label