Skip to content
Snippets Groups Projects

Update of the DeMo suite (dev/minor bug fix + AFP config)

Merged Benjamin Trocme requested to merge trocme/athena:master-DeMoMarch2023-update into master
All threads resolved!

Hello,

The DeMo suite is meant to monitor the defects set in the database: https://atlasdqm.web.cern.ch/atlasdqm/DeMo/

It is a standalone suite of python scripts. I am the only developer.

The MR includes several minor improvements/bug fix as well as the configuration for AFP. The code was tested successfully.

Thanks in advance,

Benjamin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Benjamin Trocme resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • DataQuality/DataQualityUtils

    This merge request affects 7 files:

    • DataQuality/DataQualityUtils/scripts/DeMoAtlasDataLoss.py
    • DataQuality/DataQualityUtils/scripts/DeMoDaemon-grl.exe
    • DataQuality/DataQualityUtils/scripts/DeMoDaemon.exe
    • DataQuality/DataQualityUtils/scripts/DeMoGenerateWWW.py
    • DataQuality/DataQualityUtils/scripts/DeMoLib.py
    • DataQuality/DataQualityUtils/scripts/DeMoSetup.py
    • DataQuality/DataQualityUtils/scripts/DeMoUpdate.py
  • :white_check_mark: CI Result SUCCESS (hash 4cd54e03)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70511]

  • Changes look fine and CI is good. It would be good to remove the commented out code, but it shouldn't hold up the MR in this case. Sending to L2 for second check due to the size of the MR. Clara (L1)

  • I do not see any problems here, so approving....

    Pavol [as L2 MR shifter]

  • merged

  • Edward Moyse mentioned in commit e19daaa2

    mentioned in commit e19daaa2

  • Please register or sign in to reply
    Loading