Acts - Revisement of the GeometryContext & Introduction of the IActsDetectorElement

Hi everbody,

this MR introduces several changes to the ActsGeometry interfaces crucial to integrate the Muons into the Toolkit.

• IActsDetectorElement: Interface equivalent to the Trk::DetElementBase. Minimal set of functions needed on-top of the Acts::DetectorElement to deduce the ATLAS identifier, the subdetector and also to cache the final transformations in an external cache object.

• ActsGeometryContext & caching of the alignment transformations. Thus far the GeometryContext holds the complete set of the absolute positions of each GeoModel detector elements, its alignment distortions and another layer of the Acts tranformations on top. The GeoModel constants are also hold by the GeoAlignmentStores and hence the memory is duplicated in the ActsGeometryContext. Further, the cache is whiped if one of the subdetectors updates its alignment. In other words, the update of the alignment in the MS triggers the creation of a new alignment in the ID and vice versa. The ActsGeometryContext is basically a map from the particular DetectorElementTypes to the pointers of the corresponding ActsAlignmentStore. Further, the GeoModel part of the transformations is split into another temporary cache to reduce the memory foot print. The construction flag is removed as it is only used in the construction phase of the tracking geometry where the default transformation caches already serve as a fallback option. The fallback is now extended to cover also the general cases where the proper alignment store is missing in the geometry context. The ActsTrackingGeometrySvc is equipped with an extra method ensuring that each subdetector concerned has a proper alignment store, if the ActsGeometryContext is written into the ConditionsStore of athena.

• ActsDetAlignCondAlg: This new algorithm translates from the GeoModel alignment to the Acts-EDM alignment. There's to be one algorithm for each subdetector to decouple the respective movements. The ActsGeometryCondAlg picks up all subdetector alignments and saves their pointers into the GeometryContext. The ActsDetectorElements navigate through the map to find the proper alignment store.

DetectorDescription/GeoModel/GeoModelUtilities/GeoModelUtilities/GeoAlignmentStore.h

@@ -6,73 +6,57 @@
 #define GEOMODELUTILITIES_GEOALIGNMENTSTORE_H
 
 /// Ensure that the extensions for the Vector3D are properly loaded
-#include "GeoPrimitives/GeoPrimitives.h"
+#include <stdexcept>
 
-#include "GeoModelKernel/GeoVAlignmentStore.h"
-#include "GeoModelKernel/GeoDefinitions.h"
-#include "GeoModelUtilities/TransformMap.h"
 #include "AthenaKernel/CLASS_DEF.h"
 #include "AthenaKernel/CondCont.h"
-#include <stdexcept>
+#include "GeoModelKernel/GeoDefinitions.h"
+#include "GeoModelKernel/GeoVAlignmentStore.h"
+#include "GeoModelUtilities/TransformMap.h"
+#include "GeoPrimitives/GeoPrimitives.h"
 
-class GeoAlignmentStore : public GeoVAlignmentStore
-{
- public:
-  GeoAlignmentStore() {}
-  virtual ~GeoAlignmentStore() override {}
+class GeoAlignmentStore : public GeoVAlignmentStore {
+public:
+    GeoAlignmentStore() = default;
+    virtual ~GeoAlignmentStore() override = default;
 
-  virtual void setDelta(const GeoAlignableTransform*, const GeoTrf::Transform3D&) override;
-  virtual const GeoTrf::Transform3D* getDelta(const GeoAlignableTransform*) const override;
+    virtual void setDelta(const GeoAlignableTransform*, const GeoTrf::Transform3D&) override;
+    virtual const GeoTrf::Transform3D* getDelta(const GeoAlignableTransform*) const override;
 
-  virtual void setAbsPosition(const GeoVFullPhysVol*, const GeoTrf::Transform3D&) override;
-  virtual const GeoTrf::Transform3D* getAbsPosition(const GeoVFullPhysVol*) const override;
+    virtual void setAbsPosition(const GeoVFullPhysVol*, const GeoTrf::Transform3D&) override;
+    virtual const GeoTrf::Transform3D* getAbsPosition(const GeoVFullPhysVol*) const override;
 
-  virtual void setDefAbsPosition(const GeoVFullPhysVol*, const GeoTrf::Transform3D&) override;
-  virtual const GeoTrf::Transform3D* getDefAbsPosition(const GeoVFullPhysVol*) const override;
+    virtual void setDefAbsPosition(const GeoVFullPhysVol*, const GeoTrf::Transform3D&) override;
+    virtual const GeoTrf::Transform3D* getDefAbsPosition(const GeoVFullPhysVol*) const override;
 
+    bool append(const GeoAlignmentStore& other);
 
- protected:
-  TransformMap<GeoAlignableTransform,GeoTrf::Transform3D> m_deltas;
-  TransformMap<GeoVFullPhysVol,GeoTrf::Transform3D> m_absPositions;
-  TransformMap<GeoVFullPhysVol,GeoTrf::Transform3D> m_defAbsPositions;
+protected:
+    TransformMap<GeoAlignableTransform, GeoTrf::Transform3D> m_deltas;
+    TransformMap<GeoVFullPhysVol, GeoTrf::Transform3D> m_absPositions;
+    TransformMap<GeoVFullPhysVol, GeoTrf::Transform3D> m_defAbsPositions;
 
- public:
-  const TransformMap<GeoAlignableTransform,GeoTrf::Transform3D>&
-  getDeltas() const;
+public:
+    const TransformMap<GeoAlignableTransform, GeoTrf::Transform3D>& getDeltas() const;
 
-  const TransformMap<GeoVFullPhysVol,GeoTrf::Transform3D>&
-  getAbsPositions() const;
+    const TransformMap<GeoVFullPhysVol, GeoTrf::Transform3D>& getAbsPositions() const;
 
-  const TransformMap<GeoVFullPhysVol,GeoTrf::Transform3D>&
-  getDefAbsPositions() const;
+    const TransformMap<GeoVFullPhysVol, GeoTrf::Transform3D>& getDefAbsPositions() const;
 };
 
 CLASS_DEF(GeoAlignmentStore, 135648236, 1)
-CONDCONT_DEF( GeoAlignmentStore , 33985726 );
+CONDCONT_DEF(GeoAlignmentStore, 33985726);
 
 class ExcAlignmentStore : public std::runtime_error {
- public:
-  ExcAlignmentStore (const std::string& what) 
-    : std::runtime_error (what)
-    {}
-  ExcAlignmentStore (const char* what) 
-    : std::runtime_error (what)
-    {}  
+public:
+    ExcAlignmentStore(const std::string& what) : std::runtime_error(what) {}
+    ExcAlignmentStore(const char* what) : std::runtime_error(what) {}
 };
 
-inline
-const TransformMap<GeoAlignableTransform,GeoTrf::Transform3D>&
-GeoAlignmentStore::getDeltas() const { return m_deltas; }
-
-inline
-const TransformMap<GeoVFullPhysVol,GeoTrf::Transform3D>&
-GeoAlignmentStore::getAbsPositions() const { return m_absPositions; }
-
-inline
-const TransformMap<GeoVFullPhysVol,GeoTrf::Transform3D>&
-GeoAlignmentStore::getDefAbsPositions() const { return m_defAbsPositions; }
-
-#endif 
+inline const TransformMap<GeoAlignableTransform, GeoTrf::Transform3D>& GeoAlignmentStore::getDeltas() const { return m_deltas; }
 
+inline const TransformMap<GeoVFullPhysVol, GeoTrf::Transform3D>& GeoAlignmentStore::getAbsPositions() const { return m_absPositions; }
 
+inline const TransformMap<GeoVFullPhysVol, GeoTrf::Transform3D>& GeoAlignmentStore::getDefAbsPositions() const { return m_defAbsPositions; }
 
+#endif