2023-04-19: merge 23.0 into master

Fixed conflicts:

• Calorimeter/CaloTools/CMakeLists.txt
• InnerDetector/InDetConfig/python/SiClusterizationToolConfig.py
• PhysicsAnalysis/JetTagging/JetTagMonitoring/share/JetTagMonitoring_jobOptions.py

This sweep contains the following MRs:

• !61689 (merged) Make unmerged CAs to complain when deleted Core
• !62420 (merged) Rm some not very useful finalize methods Calorimeter, MuonSpectrometer, Tile
• !62448 (merged) Configure MuonIdHelperSvc correctly for legacy config HITSMerge_tf.py jobs Simulation
• !62444 (merged) MuonReadoutGeometry - Fix crash in Debug build MuonSpectrometer
• !62463 (merged) DataQualityInterfaces: Fix gcc13 compilation of uint types DQ
• !62460 (merged) RecExCommon: fix legacy monitoring Analysis, BTagging, Core, DQ, JetEtmiss, Reconstruction
• !62404 (merged) ATLASG-2510: allows to keep only best conversion vertex Derivation, Egamma
• !62443 (merged) JetMomentTools: Fix compilation in AnalysisBase. JetEtmiss, Reconstruction
• !62458 (merged) InDetSurveyConstraintTool: thread-checker fixes InnerDetector
• !62450 (merged) Enable missing AthSimulation ART jobs Build, Simulation
• !62447 (merged) Restore kwargs in CA interface for SiClusterizationTool configs InnerDetector, Tracking
• !62451 (merged) PRDtoTrackMap : Use ArenaPoolSTLAllocator InnerDetector, Tracking
• !62441 (merged) Remove legacy LLP1 config Derivation
• !62439 (merged) Try to return SiCharge by reference Digitization, InnerDetector
• !62433 (merged) Update BSignalFilter.cxx -- fix a 10 y.o. bug. Generators
• !62332 (merged) Add Micromega cabling map & alg MuonSpectrometer
• !62465 (merged) B-physics trigger: add new dimuon bBmux_BdmuDstarX chains for R(D*) measurement (ATR-27341) Trigger, TriggerMenu, changes-trigger-counts
• !62440 (merged) Fix legacy configuration of MuonIdHelperSvc Database, MuonSpectrometer, Simulation, Trigger
• !62437 (merged) fixing inclusion of legacy L1 MET/sumET in AODs produced by L1TopoSimulationConfig Trigger
• !62141 (merged) AF3: mirror showers for positrons and negative hadrons Run2-AF3-output-changed, Simulation, Tools, frozen-tier0-violating
• !62077 (merged) Adding anti-bb tagger DL1dbb and gn1+bb test chains BTagging, Trigger, TriggerEDM, TriggerMenu, changes-trigger-counts
• !62432 (merged) Bug fix such that thinning does not run in reco from ESD workflows. JetEtmiss, Reconstruction
• !62425 (merged) Remove obsolete checkMetaSG in favour of meta-reader Core, Tools
• !62423 (merged) Remove some calls to find_package(CLHEP) if clhep is not used Calorimeter, Digitization, ForwardDetectors, HGTD, LAr, Overlay, Simulation
• !62422 (merged) Remove the unused boost subpackages from find_package(), add missing Analysis, Calorimeter, Core, Digitization, JetEtmiss, LAr, MuonSpectrometer, Reconstruction, Simulation, TestBeam, Tile, Trigger
• !62421 (merged) Isolation Truth avoid conditional decorations see ATLASG-2504 Derivation
• !62417 (merged) TRT_TrackSegmentsTool_xk: Thread-safety cleanup. InnerDetector
• !62416 (merged) PyDumper: Get MuonIdHelperSvc initialized properly. EDM
• !62415 (merged) AthenaKernel+CxxUtils: Mixed container trimming workaround. Core
• !62414 (merged) DerivationFrameworkMCTruth: Fix usage of decoration handles. Derivation
• !62409 (merged) Fix flake8 in VS Code Build
• !62413 (merged) we do not seem to really use PerfDPD_EOverP.py. Archive Analysis
• !62408 (merged) TrkExTools : Clang fixes for unused const variable Tracking
• !62369 (merged) TRTOverlay use DataPool InnerDetector, Overlay
• !62365 (merged) Add cosmic+low energy track selection for IDGlobal DQ and small bugfixes DQ, InnerDetector, Tracking
• !61914 (merged) Workaround jet CA reordering by flattening the accumulator and returning dependencies as is Analysis, Core, Derivation, Generators, JetEtmiss, Reconstruction
• !62424 (merged) add b+tau chains for HH->bbtautau Trigger, TriggerMenu, changes-trigger-counts
• !62412 (merged) Remove calls to find_package(boost) in packages that don't use boost Trigger
• !62411 (merged) TrigP1Test: move RAWtoALL to CA for test_trigP1_v1PhysP1_T0MonTrf_run2_build Trigger
• !62434 (merged) fix TrigT1ResultByteStreamConfig test for legacy with missing ROBs Trigger
• !62418 (merged) CrestApi+TrigT1RPClogic: Fix cppcheck warnings. Database, Trigger
• !62431 (merged) ATR-27227: update test refs and fix online monitoring test Core, DQ, Trigger
• !62399 (merged) Modify Jet Trigger Efficiency Algorithm for gfex trigger emulation DQ, JetEtmiss, Trigger
• !62324 (merged) ATR-23061, ATR-26394: Split FS tracking beamspot chains to reduce BeamSpotPEB rate Trigger, TriggerMenu, changes-trigger-counts
• !62385 (merged) Store electron LH as float rather than double Derivation, Egamma, changes-derivation-output
• !62380 (merged) PixelG4_SD+SCT_G4_SD: cmake fix InnerDetector, Simulation
• !61583 (merged) Seperated logging out from TFCSParmaterizationBase Simulation
• !62360 (merged) TileTBRec+TileRecUtils: Switch off FELIX data in h1000 ntuple by default Tile
• !62377 (merged) JetMomentTools: Add RenounceOutput option for JetForwardJvtTool. JetEtmiss, Reconstruction
• !62390 (merged) Remove find_package(Boost) from packages where boost is not used Calorimeter, ForwardDetectors, Generators, InnerDetector, Simulation, Tools
• !62389 (merged) MuonGMTest - Use the IdentifierHash to loop over the readout elements MuonSpectrometer
• !62358 (merged) Style formatting InDet derivation configs Derivation, InnerDetector, Tracking
• !62381 (merged) Cleanup PrimaryDPD 3 . Followup to MR62310 Analysis
• !62376 (merged) AthenaServices: Clear exceptions in FPEControlSvc. Core
• !62388 (merged) Delete AmdcMGM package MuonSpectrometer
• !62400 (merged) Remove calls to find_package(Boost) in the packages which don't use boost DQ, Digitization, LAr, MuonSpectrometer, Simulation
• !62401 (merged) Remove calls to find_package(Boost) in the packages which don't use boost, part3 ACTS, Analysis, Simulation, Tile, Tracking
• !62352 (merged) AtlasSemantics: Fix VarHandleArraySemantics for default value append Core, Simulation
• !62397 (merged) filter harmonization BTagging DQ ATLAS ready Analysis, BTagging, DQ, JetEtmiss
• !62374 (merged) OptionalContainer seems to have never found its use. Archive Core
• !62368 (merged) Adding legacy UPC triggers, without ZDC Trigger, TriggerMenu, TriggerMinBias
• !62393 (merged) [ATR-27227] Add service creation to trigger xAODConfig svc when not in INFILE mode Trigger
• !62398 (merged) TrfTestsART: Change tests to CA and use flags.DQ.Steering.doHLTMon=False Tools
• !62378 (merged) JetSelectorTools: Add SuppressOutputDependnece option for EventCleaningTool. Analysis, JetEtmiss
• !62379 (merged) TrigT1CaloTools: Mark L1TriggerTowerTool as not thread-safe. Trigger
• !62362 (merged) ATR-23602: Add LUCID monitored items and clean up ALFA_Diff_Phys Trigger, TriggerMenu
• !62382 (merged) Pad trigger decoding: use uint32_t explicitly to avoid -Wsign-conversion MuonSpectrometer, Trigger
• !62359 (merged) ATR-27270: jet/b-jet trigger physics menu downshift Trigger, TriggerMenu, changes-trigger-counts
• !62349 (merged) Adding ReadDecorHandleKey for ptcone20 in the electron mon algos DQ, Egamma, Trigger
• !62179 (merged) Delete the MuonDetector elements MuonSpectrometer
• !62357 (merged) Update d0/z0significance helpers to work in PHYSLITE (ATLASG-2509) EDM, Tracking
• !62373 (merged) MuonRecExample - Fix TCT tests MuonSpectrometer
• !62375 (merged) Fix failing ART tests after rm of legacy PrimaryDPD JO Tools

added full-unit-tests label

mentioned in merge request !62447 (merged)

marked this merge request as ready

This merge request affects 87 packages:

• .devcontainer
• .vscode
• Calorimeter/CaloLocalHadCalib
• Calorimeter/CaloTools
• Calorimeter/CaloTrackingGeometry
• Control/AthAnalysisBaseComps
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExHive
• Control/AthenaKernel
• Control/AthenaMonitoring
• Control/CxxUtils
• Control/PileUpComps
• Control/Valkyrie
• DataQuality/DataQualityInterfaces
• Database/AthenaPOOL/AthenaPoolUtilities
• Database/CrestApi
• Event/PyDumper
• ForwardDetectors/AFP/AFP_Reconstruction/AFP_GlobReco
• ForwardDetectors/AFP/AFP_Reconstruction/AFP_VertexReco
• Generators/GeneratorFilters
• HighGranularityTimingDetector/HGTD_Digitization/HGTD_Overlay
• InnerDetector/InDetAlignTools/InDetSurveyConstraintTool
• InnerDetector/InDetConfig
• InnerDetector/InDetDigitization/SiDigitization
• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetMonitoring/InDetGlobalMonitoringRun3Test
• InnerDetector/InDetRawAlgs/InDetOverlay
• InnerDetector/InDetRecAlgs/InDetTrackPRD_Association
• InnerDetector/InDetRecTools/TRT_TrackSegmentsTool_xk
• LArCalorimeter/LArCafJobs
• LArCalorimeter/LArG4/LArG4H6SD
• LArCalorimeter/LArG4/LArHitAlgs
• LArCalorimeter/LArTest/LArEventTest
• MuonSpectrometer/MuonCablings/MuonCablingData
• MuonSpectrometer/MuonCablings/MuonMM_Cabling
• MuonSpectrometer/MuonCnv/MuonCnvExample
• MuonSpectrometer/MuonCnv/MuonMM_CnvTools
• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondTest
• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• MuonSpectrometer/MuonGeoModelTest
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkLLP
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
• PhysicsAnalysis/JetTagging/JetTagMonitoring
• PhysicsAnalysis/PhysicsValidation/PhysValMonitoring
• PhysicsAnalysis/PrimaryDPDMaker
• PhysicsAnalysis/RingerSelectorTools
• Projects/AthSimulation
• Reconstruction/Jet/JetEvent
• Reconstruction/Jet/JetMomentTools
• Reconstruction/Jet/JetRec
• Reconstruction/Jet/JetRecConfig
• Reconstruction/RecExample/RecExCommon
• Reconstruction/eflowRec
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
• Simulation/SimuJobTransforms
• Simulation/Tests/DigitizationTests
• Simulation/Tests/ISF_ValidationMT
• TestBeam/TBRec
• TileCalorimeter/TileRecUtils
• TileCalorimeter/TileTrackingGeometry
• Tools/PyUtils
• Tools/WorkflowTestRunner
• Tracking/TrkEvent/TrkEventUtils
• Tracking/TrkExtrapolation/TrkExTools
• Trigger/TrigEvent/TrigCombinedEvent
• Trigger/TrigEvent/TrigCombinedEventTPCnv
• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigHypothesis/TrigBphysHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigT1/L1Topo/L1TopoConfig
• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/TrigT1CaloTools
• Trigger/TrigT1/TrigT1MBTS
• Trigger/TrigT1/TrigT1NSW
• Trigger/TrigT1/TrigT1RPClogic
• Trigger/TrigT1/TrigT1ResultByteStream
• Trigger/TrigTools/TrigByteStreamTools
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @jchapman ,@cgrefe ,@jmharris ,@jmellent ,@cohm ,@okumura ,@carquin ,@lgagnon ,@bernius ,@jcatmore ,@ahaas ,@sekula ,@zmarshal ,@lyubushk ,@tkharlam ,@sroe ,@mnowak ,@hrussell ,@ahasib ,@mhodgkin ,@pscholer ,@serodrig ,@suyogs ,@shanisch ,@tadej ,@rbianchi ,@martindl ,@rosati ,@maszyman ,@vimartin ,@stavrop ,@abarton ,@gavrilen ,@solodkov ,@cmorenom ,@aporeba ,@malconad ,@cantel ,@sutt ,@jburzyns ,@salderwe ,@jveatch ,@ispokhar ,@tamartin ,@calpigia ,@cpollard ,@fpastore ,@ggonella ,@vmartin ,@orlando ,@xiaozhon ,@jojungge ,@okuprash ,@iouri ,@dguest ,@schaarsc ,@pjacka ,@pavol ,@amete ,@gemmeren ,@paulama ,@oliveirg ,@wleight ,@ssnyder ,@goetz ,@dshope ,@mfauccig ,@akraszna ,@asonay ,@gipezzul ,@lidiaz ,@amorley ,@iriu ,@dtrischu ,@harkusha ,@apsallid ,@calfayan ,@ademaria ,@thompson ,@lshan ,@nelsonc as watchers

added Analysis BTagging Build CaloRinger Calorimeter Core DQ Database Derivation Digitization EDM ForwardDetectors Generators HGTD InnerDetector JetEtmiss LAr MuonSpectrometer Overlay Reconstruction Simulation TestBeam Tile Tools Tracking Trigger TriggerEDM TriggerMenu analysis-review-required changes-trigger-counts master review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

400K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py

420K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

244K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

CI Result SUCCESS (hash a5c40346)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70091]

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit d3dd2df9

added sweep:ignore label