Skip to content
Snippets Groups Projects

Pass EventContext down to SiTrajectory methods

Merged Stewart Martin-Haugh requested to merge smh/athena:SiTrajectory_context into 23.0
All threads resolved!

Remove two calls to currentContext() by passing EventContext down.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • There are several CI test errors reported, potentially related to Bad EventContext, so I guess this might be related. Can you please investigate? Thanks

    Thomas - L1

  • added 2 commits

    Compare with previous version

  • Author Developer

    The crashes were due to another EventContext implicit conversion, this time from int. Of course, I should have tested it more thoroughly locally. Would have been caught at compile time by gaudi/Gaudi!1446 (merged)

    Edited by Stewart Martin-Haugh
  • Stewart Martin-Haugh resolved all threads

    resolved all threads

  • This merge request affects 2 packages:

    • InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
    • InnerDetector/InDetRecTools/SiCombinatorialTrackFinderTool_xk

    Affected files list will not be printed in this case

    Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

  • :white_check_mark: CI Result SUCCESS (hash 0b7bb055)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70417]

  • Julien Maurer mentioned in commit b81352d3

    mentioned in commit b81352d3

  • merged

  • Edward Moyse mentioned in merge request !62681 (merged)

    mentioned in merge request !62681 (merged)

  • Please register or sign in to reply
    Loading