Remove deprecated UpgradePerformanceFunctions

added Upgrade label

I've since discussed this briefly with @egramsta (we share an office) and on second thought, it might be good to first understand to what extent this truth smearing workflow is still useful for certain studies. From what I gather about his use-case, it's actually rather for a modelling of the current detector.

Hi @tstreble, @dshope

The truth-smearing is indeed used by several physics analyses in e.g. the SUSY group through the SimpleAnalysis framework (https://simpleanalysis.docs.cern.ch/). E.g. see the documentation on smearing here: https://simpleanalysis-internal.docs.cern.ch/tutorial/smearing/. For instance is the smearing used to get a feeling on variables like the significance of the missing transverse energy which is used by several SUSY-analyses (and which does not have any meaning before detector reconstruction/smearing is applied). As David says the tool is mostly used to smear assuming Run2/Run3 geometry and less for actual upgrade (run4) studies.

I haven't written the SimpleAnalysis interface to the UpgradeFunctions myself (TruthSmear.cxx). Up till now I've simply used it blindly, assuming it was using the recommended functions, to apply smearing. It was when I updated the SimpleAnalysis to rel. 22 I started looking into the details.

Would maybe be good to include a few more people to get their opinion on this (SUSY Background forum conveners; @mrimoldi, @miholzbo). Smearing is not yet used in rel. 22 (the TruthSmear.cxx was simply removed to allow the code to compile). However, I have implemented a working version in rel 22 using the UpgradeFunctions.

best, Eirik

This merge request affects 1 package:

PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions

This merge request affects 23 files:

PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/CMakeLists.txt
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/README
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/ElectronPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/FlavourTaggingPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/JetPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/LinkDef.h
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/MissingETPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/MuonPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/PhotonPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/PileupOverlay.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/TauPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/TrackingPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/TriggerPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/Root/UpgradePerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/UpgradePerformanceFunctions/ATLAS_CHECK_THREAD_SAFETY
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/UpgradePerformanceFunctions/UpgradePerformanceFunctions.h
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/share/PhotonFakes.root
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/share/flavor_tags_v1.0.root
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/share/flavor_tags_v1.1.root
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/share/flavor_tags_v1.2.root
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/share/sumetPU_mu200_ttbar_gold.root
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/util/plotPerformanceFunctions.cxx
PhysicsAnalysis/UpgradePhys/SmearingFunctions/UpgradePerformanceFunctions/util/testPerformanceFunctions.cxx

Adding @demers ,@jchapman ,@amorley ,@nielsenj ,@spagan ,@cohm ,@tkharlam ,@ahaas ,@tadej as watchers

added 23.0 Analysis BTagging Egamma JetEtmiss Overlay Tau Trigger review-pending-level-1 labels

CI Result SUCCESS (hash a5fddef1)

	Athena	AthSimulation	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70389]