Skip to content
Snippets Groups Projects

Updated PU check for TruthClusterizationFactory [ATLITKSW-216]

Merged Updated PU check for TruthClusterizationFactory [ATLITKSW-216]
tstreble/athena:TruthClusterPUFix into master
All threads resolved!
Merged Thomas Strebler requested to merge tstreble/athena:TruthClusterPUFix into master
All threads resolved!

Now that some reasonable full-truth config has been identified, the TruthClusterizationFactory implementation has been investigated with a full-truth sample. It turns out that the eventIndex check simply needs to be updated to check the actual eventNumber from the EventInfo. In case of HepMcParticle from PU, this check will fail and they can be discarded based on this. The tweak in the configuration can thus be dropped. Fix ATLITKSW-216

FYI @pagessin @lgagnon

Merge request reports

Pipeline #5472834 passed

Stage: external

    Pipeline passed for 58e4cb57 on tstreble:TruthClusterPUFix

    Approval is optional

    Merged by Edward MoyseEdward Moyse 1 year ago (Apr 25, 2023 8:08am UTC)

    Merge details

    • Changes merged into master with eaad76a8 (commits were squashed).
    • Did not delete the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • InnerDetector/InDetConfig
    • InnerDetector/InDetRecTools/SiClusterizationTool

    Affected files list will not be printed in this case

    Adding @goetz ,@amorley ,@lgagnon ,@sroe as watchers

  • ATLAS Robot added InnerDetector master review-pending-level-1 labels

    added InnerDetector master review-pending-level-1 labels

  • Thomas Strebler added 1 commit

    added 1 commit

    • 58e4cb57 - Updated PU check for TruthClusterizationFactory

    Compare with previous version

  • Thomas Strebler resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 8d2cffdb)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70411]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • InnerDetector/InDetConfig
    • InnerDetector/InDetRecTools/SiClusterizationTool

    Affected files list will not be printed in this case

    Adding @goetz ,@amorley ,@lgagnon ,@sroe as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 58e4cb57)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70421]

  • Kira Abeling added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Kira Abeling
    Kira Abeling @kiabelin ·
    Developer

    Changes and CI look fine. Approving.

    Kira (L1)

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit eaad76a8

    mentioned in commit eaad76a8

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Thomas Strebler mentioned in merge request !63452 (merged)

    mentioned in merge request !63452 (merged)

    • Please register or sign in to reply