Updating jFEX MET simulation

This MR is meant to update the jFEX met simulation. It solve one problem found on the FWD MET calculation as well as some rounding issues.

It modifies the interface of the EDM to retrieve the Ex and Ey to take into account the hemisphere sign.

added Run3L1Calo label

This merge request affects 2 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @tamartin ,@thompson ,@akraszna ,@serodrig as watchers

added 23.0 EDM JetEtmiss Trigger analysis-review-required review-pending-level-1 labels

added Run3-DataReco-output-changed label

CI Result FAILURE (hash 205f92fa)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70431]

added 1 commit

• 6676fc10 - Updating ref.

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@salderwe ,@vmartin ,@okumura ,@tamartin ,@akraszna ,@serodrig ,@thompson as watchers

added changes-trigger-counts label

WARNING: big files (>100K) are found in the changeset

260K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

452K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

I guess I need your help @tamartin, the problem mostly is that now we should consider for the Ex and Ey the sign depending on the hemisphere. I have just changed the function to call Ex and Ey, not the AuxContainer. Was a request from L1Topo - tagging also @rgugel in case he wants to comment also.

CI Result FAILURE (hash 6676fc10)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70445]

added review-user-action-required label and removed review-pending-level-1 label

There is one test failing. Could you chack if that is expected @serodrig and follow the instructions provided if it is?

Thanks, Kira (L1)

Ah, OK - so while the changes are in the sim & interface, the values stored in the aux are modified.

So this is then important for MC as it is changing the Phase-I sim and the HLT_xe30_cell_xe30_tcpufit_L1jXE70 chain.

It would not normally be considered frozen tier 0 violating, but it is here on a technicality.

ERROR    Py:diff-root         INFO  [xAOD::jFexMETRoIAuxContainer_v1_L1_jFexMETRoI_OfflineCopyAux.tobEx]: 111 leaves differ
ERROR    Py:diff-root         INFO  [xAOD::jFexMETRoIAuxContainer_v1_L1_jFexMETRoI_OfflineCopyAux.tobEy]: 108 leaves differ

Reminder that the "OfflineCopy" collections are duplicates of ROI collections which we would have produced at P1 (and subsequently frozen in the bytestream) in 2022 had Phase-I ROI decoding been enabled for at P1 for all of 2022. But it wasn't - so we make do with T0-created "Copy" collections instead for the time being.

added 1 commit

• 60bf0d34 - avoiding fTO violation

Compare with previous version

resolved all threads

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 4 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@salderwe ,@vmartin ,@okumura ,@tamartin ,@akraszna ,@serodrig ,@thompson as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

272K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

476K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

Okay with the change i have made it should not violate the fT0 policy and therefore, the test should pass, since i am not modifying the data written on disk.

CI Result FAILURE (hash 60bf0d34)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70538]

I will investigate these trigger count changes, but i think they are too large.. pinging @martindl and @hpacey. Most probable is that due to this sign change that depends on the hemisphere, i will introduce a bug in the MET algorithms. Can you please take a look if you are considering also the sign and if we are applying it twice?

removed Run3-DataReco-output-changed label

added review-user-action-required label and removed review-pending-level-1 label

added 224 commits

• 60bf0d34...9be693cd - 219 commits from branch atlas:23.0
• a8b3060d - Updating jFEX MET simulation
• cdc4ec1e - Updating ref.
• 352efeab - avoiding fTO violation
• 67664a50 - prints
• caffe02a - removing prints

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@salderwe ,@vmartin ,@okumura ,@tamartin ,@akraszna ,@serodrig ,@thompson as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

276K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

480K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

resolved all threads

CI Result FAILURE (hash caffe02a)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70713]

added 1 commit

• 28674643 - Updating refs.

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@salderwe ,@vmartin ,@okumura ,@tamartin ,@akraszna ,@serodrig ,@thompson as watchers

WARNING: big files (>100K) are found in the changeset

276K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

480K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

CI Result SUCCESS (hash 28674643)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70720]

Looks good, approving -- L1

removed review-pending-level-1 label

added review-approved label

added analysis-review-approved label and removed analysis-review-required label

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit 905e639d

merged

mentioned in merge request !62778 (merged)