Skip to content
Snippets Groups Projects

Adding doFastTracking configuration back into FTF ART tests

Merged Elliot Watton requested to merge ewatton/athena:ewatton-addFastTrackingFTFart into master
All threads resolved!

As title describes, flags.Tracking.doITkFastTracking=True is now added into the FastTrackFinder related ART tests within InDetPhysValMonitoring. This is due to a recent MR, which implemented a bugfix for when running the standard offline reconstruction when the fast tracking configuration is used (!62709 (merged)). This fix led to resolving efficiency losses seen for FTF when running FTF as an offline algorithm in the fast tracking configuration. Hence, this fast tracking configuration is added back into the FTF ART tests.

This MR only affects run 4 ART tests, so only master is targetted.

Edited by Elliot Watton

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Elliot Watton added 1 commit

    added 1 commit

    • c367fd63 - Avoid conflict with sweep to master of MR62664

    Compare with previous version

  • This merge request affects 1 package:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    This merge request affects 2 files:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring/test/test_run4_mu100_FTF.sh
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/test/test_run4_ttbar_PU200_FTF.sh

    Adding @goetz ,@lgagnon ,@sroe ,@keli as watchers

  • :white_check_mark: CI Result SUCCESS (hash c367fd63)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70706]

  • :white_check_mark: CI Result SUCCESS (hash 58843511)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70701]

  • Thomas Strebler resolved all threads

    resolved all threads

  • Elliot Watton added 177 commits

    added 177 commits

    Compare with previous version

  • Elliot Watton resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    This merge request affects 2 files:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring/test/test_run4_mu100_FTF.sh
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/test/test_run4_ttbar_PU200_FTF.sh

    Adding @goetz ,@lgagnon ,@sroe ,@keli as watchers

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • Elliot Watton changed the description

    changed the description

  • :white_check_mark: CI Result SUCCESS (hash f29a9fe5)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70788]

  • Looks good to me. Approved.

    Cheers L1

  • mentioned in commit 206b5605

  • Please register or sign in to reply
    Loading