Skip to content
Snippets Groups Projects

jFEX MET fixing hemisphere sign

Merged Sergi Rodriguez Bosca requested to merge serodrig/athena:METround into 23.0

This MR is meant to solve one rounding problem due to the wrong place when assign the hemisphere sign.

With this MET and SumET algorithms are matching 100% for jFEX simulation.

PS. Applying noise cuts - Pileup subs. not studied yet

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 11fb3f1a - moving the sign out of the get function

    Compare with previous version

  • This merge request affects 2 packages:

    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXToolInterfaces

    Affected files list will not be printed in this case

    Adding @thompson ,@serodrig as watchers

  • Sergi Rodriguez Bosca resolved all threads

    resolved all threads

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 11fb3f1a)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70812]

  • Looks even better to me. Approved.

    Cheers L1

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading