L2SA resolution modeling and L2SA pT extrapolation to IP for muComb

There has been a long-standing issue in muComb due to wrong L2SA pT resolution modeling. We also found L2SA pT is wrongly extrapolated to IP in muComb, even though L2SA pT is already the value at IP. So energy loss in the calorimeter is counted two times. This MR updates the L2SA expected resolution, and fixes these issues, based on 2022 data. In |eta| ~ 0.6, we found poor L2SA pT resolution, so tentatively assign an expected pT resolution of 100% for the region. The efficiency curves below are estimated with Zmumu MC. They show better L2CB rejection of low pT, keeping plateau efficiency.

ping @okumura, @vippolit , @yochi , @sshaw and @tamartin

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigL2MuonSA
• Trigger/TrigAlgorithms/TrigmuComb

Affected files list will not be printed in this case

added 23.0 Trigger review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash e13994f6)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70894]

added review-user-action-required label and removed review-pending-level-1 label

Due to your change the vec variable becomes obsolete, so please remove it. Furthermore the trigger tests are failing, so if the chages are expected please update the references. Lastly, your MR incldes a bunch of magic numbers. It would be good to put in at least a comment saying what those are.

Thanks, Kira (L1)

added 37 commits

• e13994f6...abad4933 - 34 commits from branch atlas:23.0
• d4aec7ca - Merge branch '23.0' of https://gitlab.cern.ch:8443/atlas/athena into L2SApTResolModel
• c8acc32e - remove unused variable
• fca38517 - update reference

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigAlgorithms/TrigL2MuonSA
• Trigger/TrigAlgorithms/TrigmuComb
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@salderwe ,@vmartin ,@okumura as watchers

added changes-trigger-counts review-pending-level-1 labels and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

480K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

276K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash fca38517)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70912]

I have three style comments on the code.

There is also still a failing test. Please have a look at it.

 noerror.sh> ERROR: Found the following errors in Trigger_athenaHLT_v1Dev.log:
chainComp ERROR    Trigger counts differ from the reference. If the above differences are intended, update the reference
 noerror.sh> ERROR: Test Trigger_athenaHLT_v1Dev failed with exit code: 1
 noerror.sh> Please check /build/ci-builds/23.0/Athena/build/Athena/AtlasTest/CITest/CMakeFiles/ciTestRun/Trigger_athenaHLT_v1Dev/Trigger_athenaHLT_v1Dev.log

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 07c77fb8 - update reference

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigAlgorithms/TrigL2MuonSA
• Trigger/TrigAlgorithms/TrigmuComb
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@salderwe ,@vmartin ,@okumura as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

480K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

276K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 07c77fb8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70933]

resolved all threads

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• cec41bea - add some comments for getMuFastRes

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigAlgorithms/TrigL2MuonSA
• Trigger/TrigAlgorithms/TrigmuComb
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@salderwe ,@vmartin ,@okumura as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

480K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

276K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

resolved all threads

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash cec41bea)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70948]

added review-approved label and removed review-pending-level-1 label

I think it's better with comments now. Approving.

Kira (L1)

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit f5face7c

merged

mentioned in merge request !62861 (merged)