fix check for non physical phi in egamma IsolationCorrections

This merge request affects 1 package:

PhysicsAnalysis/ElectronPhotonID/IsolationCorrections

This merge request affects 1 file:

PhysicsAnalysis/ElectronPhotonID/IsolationCorrections/Root/IsolationCorrection.cxx

added Analysis analysis-review-required review-pending-level-1 labels

CI Result SUCCESS (hash c7df1205)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70938]

removed analysis-review-required label

added analysis-review-approved label

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

added review-approved-point1 label

added review-user-action-required label

resolved all threads

added 1 commit

7f8f5125 - make it clearer that we're excluding clusters with phi > pi

Compare with previous version

removed review-user-action-required label

added review-pending-level-1 label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 1 package:

PhysicsAnalysis/ElectronPhotonID/IsolationCorrections

This merge request affects 1 file:

PhysicsAnalysis/ElectronPhotonID/IsolationCorrections/Root/IsolationCorrection.cxx

removed review-approved review-approved-point1 labels

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

@kiabelin you can re-approve if you're satisfied (code is identical to before but the number 3.14159 (which is float(M_PI)) was replaced with the symbolic expression to make it clearer

Giovanni

CI Result SUCCESS (hash 7f8f5125)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70973]