Remove hits in third time bin variable for xAOD::StripCluster

It looks like this variable has never been used in the past. We can always add it back should we need it in the future

/cc @ncalace @lgagnon

added ACTS EDM labels

This merge request affects 7 packages:

• Event/xAOD/xAODInDetMeasurement
• InnerDetector/InDetMeasurementUtilities
• InnerDetector/InDetValidation/InDetPhysValMonitoring
• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrkAlgs/ActsTrkAnalysis
• Tracking/Acts/ActsTrkTools/ActsTrkAnalysisTools
• Tracking/Acts/ActsTrkTools/ActsTrkClusterizationTools

Affected files list will not be printed in this case

Adding @goetz ,@lgagnon ,@sroe ,@keli ,@pagessin ,@jojungge ,@tbold ,@akraszna ,@toyamaza ,@cvarni as watchers

added InnerDetector Tracking analysis-review-required master review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 655c1df6)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 71131]

added 6 commits

• 655c1df6...2442253a - 2 commits from branch atlas:master
• 19bcb0bc - Remove old EDM converters for clusters
• b5589856 - Merge remote-tracking branch 'origin/RemoveOldConverter' into RemoveHitsInThirdTimeBinVariable
• 26b34d42 - update
• 8fc960f8 - third round

Compare with previous version

This merge request affects 8 packages:

• Event/xAOD/xAODInDetMeasurement
• InnerDetector/InDetMeasurementUtilities
• InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation
• InnerDetector/InDetValidation/InDetPhysValMonitoring
• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrkAlgs/ActsTrkAnalysis
• Tracking/Acts/ActsTrkTools/ActsTrkAnalysisTools
• Tracking/Acts/ActsTrkTools/ActsTrkClusterizationTools

Affected files list will not be printed in this case

Adding @goetz ,@lgagnon ,@sroe ,@keli ,@pagessin ,@jojungge ,@tbold ,@akraszna ,@toyamaza ,@cvarni as watchers

marked this merge request as draft

CI Result SUCCESS (hash 8fc960f8)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 71140]

resolved all threads

marked this merge request as ready

marked this merge request as draft

removed review-pending-level-1 label

marked this merge request as ready

added review-pending-level-1 label

Hi @lgagnon is also

 StringProperty m_timeBinStr{this, "timeBins", ""};

supposed to be removed? I see that the strip clustering tool does something with it when decodeTimeBins is called. Should all these be removed now, or am I missing something?

added review-user-action-required label and removed review-pending-level-1 label

Marking as review-user-action-required until the thread is resolved.

Cheers L1

resolved all threads

added review-pending-level-1 label and removed review-user-action-required label

@jnitschk thread resolved. thanks

added review-approved label and removed review-pending-level-1 label

Looks good to me now. Approved.

Cheers L1

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit 6f163d3a

added sweep:ignore label