Skip to content
Snippets Groups Projects

TrigMinBias: Fix configuration for Pixel SPs veto chains

Merged Krzysztof Ciesla requested to merge kciesla/athena:minbias_pixveto_fix into 23.0
All threads resolved!

This MR fixes configuration for MinBias chains using pixel veto, e.g. HLT_mb_sp_vpix15_hi_FgapAC3_L1RD0_FILLED. Due to the method how SPs counting chains are configured, the minimum number of Pixel and SCT SPs was mistakenly set for vpixNN chains. This MR also adds more debug messages for SPCountingHypoTool.

CC: @asmaga @kdomijan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jiri Masik
  • added 1 commit

    • 0854b714 - Reduced number of debug message lines; Made indentation consistent

    Compare with previous version

  • This merge request affects 2 packages:

    • Trigger/TrigAlgorithms/TrigMinBias
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@lidiaz as watchers

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash ed3244e2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 71938]

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 0854b714)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 71942]

  • Kira Abeling resolved all threads

    resolved all threads

  • added review-approved label and removed review-pending-level-1 label

  • Comments have been adressed and changes and CI look fine. Approving.

    Kira (L1)

  • Andrea Coccaro mentioned in commit 9eb56233

    mentioned in commit 9eb56233

  • merged

  • Adam Edward Barton mentioned in merge request !63310 (merged)

    mentioned in merge request !63310 (merged)

  • Please register or sign in to reply
    Loading