Move the `WeightHelpers` to its only client
Move the WeightHelpers
to its only client.
This MR:
- just moves the code, but does not delete anything
- will result in TruthUtils being a header-only library
- prevent the overlinkage of the
WeightHelpers
code into hundreds of packages where it is not used. - commented out the WeightHelpers test
Merge request reports
Activity
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
added 23.0 Analysis Generators analysis-review-required review-pending-level-1 labels
- Resolved by Andrii Verbytskyi
CI Result FAILUREAthena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make N/A N/A N/A N/A N/A tests N/A N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72288]added review-user-action-required label and removed review-pending-level-1 label
added 57 commits
-
9c3998dd...dbc9531a - 56 commits from branch
atlas:23.0
- a9509e36 - Merge remote-tracking branch 'upstream/23.0' into move_weights
-
9c3998dd...dbc9531a - 56 commits from branch
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILUREAthena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make N/A N/A N/A N/A N/A tests N/A N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72358]added review-user-action-required label and removed review-pending-level-1 label
added 41 commits
-
a9509e36...4c213d86 - 39 commits from branch
atlas:23.0
- 1fd61d54 - Merge remote-tracking branch 'upstream/23.0' into move_weights
- db7d9bed - OK
-
a9509e36...4c213d86 - 39 commits from branch
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
added review-pending-level-1 label and removed review-user-action-required label
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
CI Result FAILUREAthena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make N/A N/A N/A N/A N/A tests N/A N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72426]This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
CI Result FAILUREAthena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make N/A N/A N/A N/A N/A tests N/A N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72432]added review-user-action-required label and removed review-pending-level-1 label
CI Result FAILURE (hash 36f36938)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 2, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
AthGeneration: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 2, warnings 0
AthAnalysis: number of compilation errors 2, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72431]added 10 commits
-
4de58171...10422474 - 8 commits from branch
atlas:23.0
- ca2ce9d4 - OK
- 2d510e26 - Merge remote-tracking branch 'upstream/23.0' into move_weights
-
4de58171...10422474 - 8 commits from branch
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
added review-pending-level-1 label and removed review-user-action-required label
added review-user-action-required label and removed review-pending-level-1 label
CI Result FAILURE (hash 2d510e26)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72447]added 64 commits
-
2d510e26...48443847 - 62 commits from branch
atlas:23.0
- 7e9fb9df - OK
- 87eed99e - Merge remote-tracking branch 'upstream/23.0' into move_weights
-
2d510e26...48443847 - 62 commits from branch
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILURE (hash 87eed99e)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72507]Marking as review-user-action-required until the threads and CI issues are resolved.
Cheers L1
removed review-pending-level-1 label
added review-user-action-required label
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILURE (hash 864651d9)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72531]Adding tag review-user-action-required since CI issues Cheers L1
removed review-pending-level-1 label
added 27 commits
-
864651d9...ef656a18 - 25 commits from branch
atlas:23.0
- 6b5619f4 - Added init
- 9ecaf0f7 - Merge remote-tracking branch 'upstream/23.0' into move_weights
-
864651d9...ef656a18 - 25 commits from branch
This merge request affects 2 packages:
- Generators/TruthUtils
- PhysicsAnalysis/AnalysisCommon/PMGTools
Affected files list will not be printed in this case
Adding @zmarshal as watcher