Trying to reduce number of string comparisions in TrigTauRecMerged

Improvement related to ATR-27533, pining @khoo @smwang

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigAlgorithms/TrigTauRec

This merge request affects 2 files:

• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauRecConfig.py
• Trigger/TrigAlgorithms/TrigTauRec/src/TrigTauRecMerged.cxx

Adding @martindl ,@ademaria ,@iriu ,@amelo ,@carquin ,@xiaozhon ,@adbailey ,@lstocker ,@malconad ,@gipezzul as watchers

added 23.0 Tau Trigger labels

CI Result SUCCESS (hash 308f0c63)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72373]

added 1 commit

• 0d96c917 - Avoid string comparisons in execute method when handling tools

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigAlgorithms/TrigTauRec

This merge request affects 2 files:

• Trigger/TrigAlgorithms/TrigTauRec/src/TrigTauRecMerged.cxx
• Trigger/TrigAlgorithms/TrigTauRec/src/TrigTauRecMerged.h

Adding @martindl ,@ademaria ,@iriu ,@amelo ,@carquin ,@xiaozhon ,@adbailey ,@lstocker ,@malconad ,@gipezzul as watchers

added 1 commit

• 50e924ed - Avoid string comparisons in execute method when handling tools

Compare with previous version

CI Result FAILURE (hash 0d96c917)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72436]

added 1 commit

• 120aa04f - Avoid string comparisons in execute method when handling tools

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigAlgorithms/TrigTauRec

This merge request affects 2 files:

• Trigger/TrigAlgorithms/TrigTauRec/src/TrigTauRecMerged.cxx
• Trigger/TrigAlgorithms/TrigTauRec/src/TrigTauRecMerged.h

Adding @martindl ,@ademaria ,@iriu ,@amelo ,@carquin ,@xiaozhon ,@adbailey ,@lstocker ,@malconad ,@gipezzul as watchers

CI Result FAILURE (hash 120aa04f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72445]

Hi @carquin, did you check already with some debug messages that the new arrays are correctly filled with the tools that you expect?

If that doesn't help figure it out, I suppose now that you defined them, you could even change the python now to assign directly to the right ones...

Yes, I did, I see the tools are scheduled in the right order and the code runs without errors

Hi @carquin , I don’t fully understand your code change. The ToolHandleArray that you are adding as configurables should be set at configuration time in the python code, and not filled based on the name of the tools in the . Maybe the m_vertexVarsTools.push_back(tool); does not work as you are expecting, since these are Handles of tools.

added 1 commit

• d0bc0540 - Avoid string comparisons in execute method when handling tools

Compare with previous version

Hi @khoo @fpastore, I implemented the configuration (see last version of the commit) of the tools in the pythin script, but still see the same error, I have tracked it down with an issue with the decisions somehow are not getting the objects, I have no clue how this could happen with this change set, to me it seems the tools are working correctly but there is an issue downstream. Cheers, Edson

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigAlgorithms/TrigTauRec

This merge request affects 3 files:

• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauRecConfig.py
• Trigger/TrigAlgorithms/TrigTauRec/src/TrigTauRecMerged.cxx
• Trigger/TrigAlgorithms/TrigTauRec/src/TrigTauRecMerged.h

Adding @martindl ,@ademaria ,@iriu ,@amelo ,@carquin ,@xiaozhon ,@adbailey ,@lstocker ,@malconad ,@gipezzul as watchers