Change place where the TrackContainer is constructed

Looks good. As well as !63217 (merged), this will also clash with !63179 (merged). I'm happy to do that before or after the others.

added ACTS label

Hi @tbold I really like these changes. This is indeed going towards what we want (remove the not-Acts track collection and have the Acts -> Athena track convertion in a different Algorithm). Can you also save the Acts Track collection in StoreGate? Something similar to what @goetz is doing with !63482 (merged) where he stores a ActsTrk::ConstTrackCollection for other algorithms to use downstream?

I'd suggest to proceed with this, and we'll adapt the Bump accordingly (also because we have to wait for that MR to go in anyway)

I'm afraid the process from making a Track Collection a Const Track Collection is not really trivial... @pagessin maybe we should introduce in ACTS a constructor with move semantics that converts the entire object from read/write to read-only?

marked this merge request as ready

This merge request affects 3 packages:

Tracking/Acts/ActsTrkAlgs/ActsTrkFinding
Tracking/Acts/ActsTrkTools/ActsTrkFindingTool
Tracking/Acts/ActsTrkTools/ActsTrkToolInterfaces

Affected files list will not be printed in this case

Adding @pagessin ,@jojungge ,@tbold ,@toyamaza ,@cvarni as watchers

added Tracking master review-pending-level-1 labels

CI Result SUCCESS (hash c3ac2742)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72518]

I think the Acts track states point to the ATLASUncalibSourceLink container. That needs to be stored as well. It might make sense to move the creation of the ATLASUncalibSourceLink container to a separate algorithm.

Yes, I think it would be cleaner to put in a separate algorithm. We want to move more conversions to separate algorithms. But is it easier to get it working, and then think about refactoring? Your !63482 (merged) saves the ATLASUncalibSourceLink. Would that be a step along the road?

Adding tag review-user-action-required until all threads are solved Cheers L1

removed review-pending-level-1 label

added review-user-action-required label

added 409 commits

c3ac2742...90d021b3 - 407 commits from branch atlas:master
538769da - Merge remote-tracking branch 'upstream/master' into master-track-finder-external-collection
964f2990 - Add recording of ConstTrackContainer

Compare with previous version

This merge request affects 4 packages:

Tracking/Acts/ActsTrkAlgs/ActsTrkFinding
Tracking/Acts/ActsTrkEvent
Tracking/Acts/ActsTrkTools/ActsTrkFindingTool
Tracking/Acts/ActsTrkTools/ActsTrkToolInterfaces

Affected files list will not be printed in this case

Adding @pagessin ,@jojungge ,@tbold ,@toyamaza ,@cvarni as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 964f2990)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73024]

Adding tag review-user-action-required until all threads are solved Cheers L1

removed review-pending-level-1 label

added review-user-action-required label

mentioned in merge request !63761 (merged)

resolved all threads

ok, lgtm

added review-pending-level-1 label and removed review-user-action-required label

Jenkins please retry a build

This merge request affects 4 packages:

Tracking/Acts/ActsTrkAlgs/ActsTrkFinding
Tracking/Acts/ActsTrkEvent
Tracking/Acts/ActsTrkTools/ActsTrkFindingTool
Tracking/Acts/ActsTrkTools/ActsTrkToolInterfaces

Affected files list will not be printed in this case

Adding @pagessin ,@jojungge ,@tbold ,@toyamaza ,@cvarni as watchers

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash 964f2990)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73095]

let's have this merge after !63179 (merged)

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label

added 157 commits

964f2990...493663e7 - 156 commits from branch atlas:master
9af59daa - Resolve conflicts

Compare with previous version

This merge request affects 4 packages:

Tracking/Acts/ActsTrkAlgs/ActsTrkFinding
Tracking/Acts/ActsTrkEvent
Tracking/Acts/ActsTrkTools/ActsTrkFindingTool
Tracking/Acts/ActsTrkTools/ActsTrkToolInterfaces

Affected files list will not be printed in this case

Adding @pagessin ,@jojungge ,@tbold ,@toyamaza ,@cvarni as watchers

added review-pending-level-1 label and removed review-approved review-user-action-required labels

CI Result SUCCESS (hash 9af59daa)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73215]