Skip to content
Snippets Groups Projects

TriggerTest: fix missing ConfigFlags import

Hello,

Two trigger ART tests are missing an import of ConfigFlags (!63175 (merged), ATR-27721). The fix uses the newly introduced syntax for flags in the trigger ART steering machinery (!63501 (merged)). Edit: the new syntax is still in development, so I rolled back to the current syntax.

Cheers, Bertrand

Edited by Bertrand Martin Dit Latour

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 3b91ef50 - go back to old/current flag syntax

    Compare with previous version

  • Bertrand Martin Dit Latour marked this merge request as ready

    marked this merge request as ready

  • Bertrand Martin Dit Latour changed title from Draft: TriggerTest: fix missing ConfigFlags import using new 'ex.flags' syntax to TriggerTest: fix missing ConfigFlags import

    changed title from Draft: TriggerTest: fix missing ConfigFlags import using new 'ex.flags' syntax to TriggerTest: fix missing ConfigFlags import

  • Bertrand Martin Dit Latour changed the description

    changed the description

  • resolved all threads

  • This merge request affects 1 package:

    • Trigger/TrigValidation/TriggerTest

    This merge request affects 2 files:

    • Trigger/TrigValidation/TriggerTest/test/test_trig_mc_v1lowMu_build.py
    • Trigger/TrigValidation/TriggerTest/test/test_trig_mc_v1lowMu_grid.py

    Adding @martindl ,@vmartin ,@okumura as watchers

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 3b91ef50)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72735]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading