Skip to content
Snippets Groups Projects

Fix bugs for Rpc offline DQ alg

Merged Shixiang Su requested to merge ssu/athena:rpc_offline_dq into 23.0
All threads resolved!

fix bugs: 1)no dbPhi panels; 2)L1 eff for thr6;

remove extra hists

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Walter LamplWalter Lampl 1 year ago (Jun 15, 2023 12:05pm UTC)

Merge details

  • Changes merged into 23.0 with 4a87a3dd (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth
  • Shixiang Su added 1 commit

    added 1 commit

    • 5bc2c585 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Shixiang Su added 1 commit

    added 1 commit

    Compare with previous version

  • Shixiang Su resolved all threads

    resolved all threads

  • Shixiang Su resolved all threads

    resolved all threads

  • This merge request affects 2 packages:

    • DataQuality/DataQualityConfigurations
    • MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/RpcRawDataMonitoring

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 284K in file DataQuality/DataQualityConfigurations/config/RPC/collisions_run.config

  • :white_check_mark: CI Result SUCCESS (hash 12f614ca)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72740]

  • Approving (L1).

  • Frank Winklmeier marked this merge request as draft

    marked this merge request as draft

  • removed master label

  • Shixiang Su added 474 commits

    added 474 commits

    • 12f614ca...4ebcec04 - 419 commits from branch atlas:master
    • 4ebcec04...51ca82d9 - 45 earlier commits
    • f4180b6e - Merge branch 'xaod.RootUtils-20230613' into '23.0'
    • 26ca246b - prevent error message when reading an empty channel name from the HV DCS
    • 1ad4b17e - Merge branch 'dealWithEmptyChannelNameFromDCS' into '23.0'
    • bbae5d57 - Remove unused OverwriteIDSummary property
    • 5c9b9bd4 - Merge branch 'tstreble-23.0-patch-48558' into '23.0'
    • db22034e - Clean up unused doLongPixels property in TotPixelClusterSplitter
    • 118d8950 - Merge branch 'TotPixelClusClean' into '23.0'
    • 7e2d5911 - fix bugs: 1)no dbPhi panels; 2)L1 eff for thr6; remove extra hists
    • c8758e7d - Apply 1 suggestion(s) to 1 file(s)
    • 52a24591 - Update RpcTrackAnaAlg.cxx

    Compare with previous version

  • Shixiang Su changed target branch from master to 23.0

    changed target branch from master to 23.0

  • Shixiang Su resolved all threads

    resolved all threads

  • Shixiang Su marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 2 packages:

    • DataQuality/DataQualityConfigurations
    • MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/RpcRawDataMonitoring

    Affected files list will not be printed in this case

    Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 284K in file DataQuality/DataQualityConfigurations/config/RPC/collisions_run.config

  • :white_check_mark: CI Result SUCCESS (hash 52a24591)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72762]

  • added review-approved label and removed review-pending-level-1 label

  • Only target branch changed. Approving.

    Kira (L1)

  • Walter Lampl mentioned in commit 4a87a3dd

    mentioned in commit 4a87a3dd

  • merged

  • Frank Winklmeier mentioned in merge request !63762 (merged)

    mentioned in merge request !63762 (merged)

  • Please register or sign in to reply
    Loading