Calo Cell children override,final un-needed virtual

LarCell/TileCell use virtual (or rm it) , override, final

• LarCell is just a few final (so avoid virtual calls if the compiler knows the concrete type)
• TileCell had quite a few methods that were marked virtual for no clear reason aka they do not override neither seem to get ever overriden. Beyond that we can also mark thigs as final so the compiler can avoid virtual calls if it knows the type.
• Leave the _novirt (which are there as I guess using the "without reason" virtual ones was slow ...). In principle this we could clean up after this MR.
• No clear why the Simul side was inheriting naively it seems to use the default setGain from CaloCell [https://acode-browser1.usatlas.bnl.gov/lxr/ident?_i=setGain]

This merge request affects 3 packages:

• LArCalorimeter/LArRecEvent
• Simulation/FastShower/FastCaloSim
• TileCalorimeter/TileEvent

Affected files list will not be printed in this case

Adding @jchapman ,@iouri ,@pavol ,@harkusha ,@solodkov as watchers

added 23.0 LAr Simulation Tile review-pending-level-1 labels

CI Result SUCCESS (hash 06bcc56d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72730]

changed the description

changed title from Calo Cell childer override,final un-needed virtual to Calo Cell children override,final un-needed virtual

added 1 commit

• a0427b93 - rm un-needed virtual also from CaloCell

Compare with previous version

This merge request affects 4 packages:

• Calorimeter/CaloEvent
• LArCalorimeter/LArRecEvent
• Simulation/FastShower/FastCaloSim
• TileCalorimeter/TileEvent

Affected files list will not be printed in this case

Adding @jchapman ,@iouri ,@pavol ,@harkusha ,@solodkov as watchers

added Calorimeter label

CI Result SUCCESS (hash a0427b93)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72733]

Hi @christos,

the FastSimXXXXCell classes are an ancient relict from Athena release 12, when FastCaloSim was still running within the reco step and there was a need to change the gain after digi. As far as I can see, they are no longer used in active code and only mentioned in #if statements checking for Athena release 12: https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Simulation/FastShower/FastCaloSim/src/AddNoiseCellBuilderTool.cxx#0073 https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Simulation/FastShower/FastCaloSim/src/EmptyCellBuilderTool.cxx#0061 https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Simulation/FastShower/FastCaloSim/src/EmptyCellBuilderTool.cxx#0082

I would suggest to complete remove the classes and the #if statements.

Cheers, Michael

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• 90c323db - clean up completely FastSimCell

Compare with previous version

This merge request affects 4 packages:

• Calorimeter/CaloEvent
• LArCalorimeter/LArRecEvent
• Simulation/FastShower/FastCaloSim
• TileCalorimeter/TileEvent

Affected files list will not be printed in this case

Adding @jchapman ,@iouri ,@pavol ,@harkusha ,@solodkov as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 90c323db)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 72759]

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit 8206d716

merged

mentioned in merge request !63762 (merged)