migrate trigger vertexing to CA config

migrate to CA vertexing config in the legacy menu

ATR-26732 as the main migration ticket

a prerequisite for ATR-27632

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetExample/InDetTrigRecExample
• Trigger/TrigTools/TrigInDetConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @goetz ,@sutt ,@ademaria ,@dshope ,@miochoa ,@nagano ,@carquin ,@sroe ,@mvozak ,@iriu ,@martindl ,@malconad ,@lidiaz ,@gipezzul ,@cantel as watchers

added 23.0 InnerDetector JetEtmiss Tau Trigger TriggerID TriggerMenu review-pending-level-1 labels

CI Result FAILURE (hash 6c0aab88)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73278]

added 1 commit

• 8571e5f2 - remove signature arg

Compare with previous version

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetExample/InDetTrigRecExample
• Trigger/TrigTools/TrigInDetConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @goetz ,@sutt ,@ademaria ,@dshope ,@miochoa ,@nagano ,@carquin ,@sroe ,@mvozak ,@iriu ,@martindl ,@malconad ,@lidiaz ,@gipezzul ,@cantel as watchers

CI Result FAILURE (hash 8571e5f2)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73286]

added 25 commits

• 8571e5f2...eed618f0 - 15 earlier commits
• 82212595 - TriggerEgamma : Fixing TrigPhotonIsolationBuilder issue mentioned in ATR-27767
• a3876a0f - FTF: HitDV optimisation + timers fix
• fce9e736 - PixelOnCluster add move ctors , clean up. Use them in SiClusterOnTrackTool
• 1d4c1362 - Only make vector of DetectorElements if needed (i.e. for Run 4) (23.0 edition)
• 0309609f - Drop boost::is_same and BOOST_STATIC_ASSERT in favor of std:: versions
• d082c888 - TileSimAlgs: Fix multiple hits for the same channel (ATLASSIM-6608)
• 1ad06455 - ATR-27757: VBF test chains to check downshift impact
• c8852ce6 - migrate trigger vertexing to CA config
• b591b000 - remove signature arg
• d886112d - ActiveConfig to Jet, ctest

Compare with previous version

added 86 commits

• d886112d...f3b6c981 - 83 commits from branch atlas:23.0
• d5627d6a - migrate trigger vertexing to CA config
• 9ccf6930 - remove signature arg
• 07e8411a - ActiveConfig to Jet, ctest

Compare with previous version

This merge request affects 4 packages:

• InnerDetector/InDetConfig
• InnerDetector/InDetExample/InDetTrigRecExample
• Trigger/TrigTools/TrigInDetConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @goetz ,@sutt ,@ademaria ,@dshope ,@miochoa ,@nagano ,@carquin ,@sroe ,@mvozak ,@iriu ,@martindl ,@malconad ,@lidiaz ,@gipezzul ,@cantel as watchers

CI Result SUCCESS (hash 07e8411a)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73305]

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

added review-approved-tier0 label

added NewConfig label

added review-approved-point1 label

mentioned in commit ab0b38be

merged

mentioned in merge request !63857 (closed)

mentioned in merge request !63939 (merged)

Hi @jmasik,

the TCT tests of yesterday's (much delayed) nightly shows differences like: Py:diff-root INFO [xAOD::VertexAuxContainer_v1_MSDisplacedVertexAux.vertexType]: 4 leaves differ

Se for example: https://bigpanda.cern.ch//media/filebrowser/d3d91e51-3b2a-48de-8ba4-1ecb7879c285/group.art/tarball_PandaJob_5890254951_ANALY_CERN_T0_ART/art-compare.log

Could that be related to this MR?

Note that the TCT test for the June 26th-nightly finished only late evening of June 27th because of an infrastructure issue.

• Walter

The changes in vertexing in tau exotic chains / tau chain are likely related to my MR - they use a different vertex reconstruction which I reported in ATR-27810. The changes in the tracking collections are unlikely related - they may be a consequence of the TrigRoIDescriptor changes for the same chains

What RoiDescriptor changes do you mean ?

Py:diff-root         INFO Found [11915597] identical leaves
Py:diff-root         INFO Found [999388] different leaves
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_Bjet.fullscan]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_Bjet.geom]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_Bjet.ids]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_Bmumux.rois]: 4 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauCore.fullscan]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauCore.geom]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauCore.ids]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauCore_probe.fullscan]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauCore_probe.geom]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauCore_probe.ids]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauIso.fullscan]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauIso.geom]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauIso.ids]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauIso_probe.fullscan]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauIso_probe.geom]: 1 leaves differ
Py:diff-root         INFO  [TrigRoiDescriptorCollection_p3_HLT_Roi_TauIso_probe.ids]: 1 leaves differ

There shouldn't beany changes in the actual RoiDescriptor itself, so do you mean that these are differences in the actual RoiDescriptors that are written out ? If so, then what would be the origin of these differences ?

Hm, trigger differences should already be being ignored by these tests here.

I refer only to the changes introduced by RDO to RDO_TRIG which are expected from regular trigger development, we should not be changing RDO to AOD.

The only offline change is this MSDisplacedVertexAux?