Skip to content
Snippets Groups Projects

ATR-27804 - Updates to jFex effective thresholds

Merged ATR-27804 - Updates to jFex effective thresholds
mmontell/athena:Menu_jFexTresholds into 23.0
Merged Marco Montella requested to merge mmontell/athena:Menu_jFexTresholds into 23.0

"This is the first attemp at the tuned thresholds with current jFEX calibration parameters. It should get us closer to turn-on curves in the correct location, but is probably not final. However, it should give us a better idea of the sort rates to expect with the new jJ items. It will be useful to observe them when we get back into physics, but I wouldn't expect to enable them immediately. Let's see what they look like first."

This MR affects counts of numerous jFex chains.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/L1CaloThresholdMapping.py
58 60:60,
59 70:70,
60 80:80,
61 85:85,
62 90:90,
53 20:15,
54 30:15,
55 40:25,
56 50:38,
57 55:44,
58 60:49,
59 70:61,
60 80:72,
61 85:79,
62 90:85,
63 63 100:100,
  • Marco Montella added 1 commit

    added 1 commit

    • fa602cbe - Updating residual jFex thresholds

    Compare with previous version

  • Marco Montella resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@salderwe ,@vmartin ,@okumura ,@lidiaz as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 244K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 428K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash fa602cbe)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73308]

  • Kira Abeling added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Kira Abeling
    Kira Abeling @kiabelin ·
    Developer

    Changes and CI look fine. Approving.

    Kira (L1)

  • Lidija Zivkovic
    Lidija Zivkovic @lidiaz ·
    Developer

    Hi @lbrenner

    this is ready to go in.

    Thanks, Lidija

  • Lydia Brenner added review-approved-point1 label

    added review-approved-point1 label

  • Lydia Brenner mentioned in commit afe65396

    mentioned in commit afe65396

  • Lydia Brenner merged

    merged

  • Adam Edward Barton mentioned in merge request !63972 (merged)

    mentioned in merge request !63972 (merged)

    • Please register or sign in to reply