Memory leakage in test program fixed

In test programs for decoders, a memory leakage due to the use of delete instead of delete [] on the buffer allocated by eformat readout function has been fixed.

added 23.0 MuonSpectrometer bugfix + 1 deleted label

removed 1 deleted label

removed 23.0 label

added 23.0 master labels

removed 23.0 label

added 23.0 label

removed 23.0 label

Hi

@epasqual .

Everything that goes to 23.0 --> is swept to master

It does not go the other way.

Adding both labels will not help much.

• If you want it for both it would be best to do one clean on top of 23.0.
• If you want it for master only this is fine.

In principle you can also cherry-pick to 23.0 at a later stage i.e let this go to master and then open a 23.0 one

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode

This merge request affects 2 files:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_common_decoder.cxx
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_trigger_common_decoder.cxx

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added review-pending-level-1 label

added 23.0 label and removed master label

added 60 commits

• e099fb15...71fb92d8 - 50 earlier commits
• 8f2c9446 - Merge branch '23.0-addingZDCitems' into '23.0'
• e53e34a7 - Resolve inconsistency in L1Threshold descriptive comments
• 5d0907c9 - Merge branch '23.0-L1Threshold-prioritycomment' into '23.0'
• 064b4001 - trigbs_extractStream.py: Add the possibility to write events with different...
• b98e1335 - Merge branch 'debug_stream_recovery' into '23.0'
• fe9dd3be - Trig_reco_tf updates - list of streams, working directory check
• 99612028 - Merge branch '23-dbgTrfStreams' into '23.0'
• 30b2a8e6 - added chains listed in ATR-27546
• 81381605 - Merge branch 'devbbtt2' into '23.0'
• 72e08a33 - In test programs for decoders, a memory leakage due to the use of delete instead of delete []

Compare with previous version

changed target branch from master to 23.0

resolved all threads

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode

This merge request affects 2 files:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_common_decoder.cxx
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_trigger_common_decoder.cxx

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

resolved all threads

CI Result SUCCESS (hash e099fb15)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73379]

CI Result SUCCESS (hash 72e08a33)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73387]

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

Hi @epasqual,

is there any reason for not using a std::unique_ptr<char[]> for memory managment. See AtlListBSEvents for example.

• Walter

resolved all threads

mentioned in commit b8e597ac

merged

mentioned in merge request !63972 (merged)

resolved all threads