Skip to content
Snippets Groups Projects

Clean up unused vertex collections in JetBTaggingAlg

Merged Thomas Strebler requested to merge tstreble/athena:BTaggingVertexCleanup into 23.0

While investigating the impact of ACTS on FTAG secondary vertexing, I noticed that the secondary vertex collections were retrieved in the JetBTaggingAlg but not used. They are instead used in the BTagLightSecVertexing tool. They are consequently removed from the JetBTaggingAlg. Run 3 derivation outputs have been checked to be unchanged.

FYI @ligang @bdong

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Strebler resolved all threads

    resolved all threads

  • CI clean and changes look good from an L1 point of view. Approving - L1

  • Thomas Strebler added 43 commits

    added 43 commits

    Compare with previous version

  • This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging

    This merge request affects 3 files:

    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging/BTagging/JetBTaggingAlg.h
    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging/python/JetBTaggingAlgConfig.py
    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging/src/JetBTaggingAlg.cxx

    Adding @dguest ,@bdong ,@lidiaz as watchers

  • Thomas Strebler resolved all threads

    resolved all threads

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 59a41d5e)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73645]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading