Skip to content
Snippets Groups Projects

Move ZAFB to jEM inputs [ATR-18966]

Merged Teng Jian Khoo requested to merge khoo/athena:23.0-TMMT-ZAFB into 23.0

Redoing !54054 (closed) now that jEMSort is implemented in L1Topo.

The ZAFB L1Topo algorithm is meant to combine central and forward electrons at L1. We had set this up in the menu with forward jets while the jEM inputs were not yet implemented.

@rgugel @jodamp Do these changes look right?

Merge request reports

Pipeline #5834621 passed

Pipeline passed for 921d92e9 on khoo:23.0-TMMT-ZAFB

Merged by Chandler Robert BakerChandler Robert Baker 1 year ago (Jul 4, 2023 6:18pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Frederic Damp
  • 📝 The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • CI Result FAILURE (hash 64752ba4)

    Athena DetCommon
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    DetCommon: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73740]

  • Teng Jian Khoo added 90 commits

    added 90 commits

    Compare with previous version

  • Teng Jian Khoo resolved all threads

    resolved all threads

  • Author Developer

    Thanks for the review, @jodamp! Should be fixed as proposed.

  • Teng Jian Khoo added 2 commits

    added 2 commits

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigT1/L1Topo/L1TopoHardware
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sutt ,@martindl ,@jmharris ,@asonay ,@iriu ,@vmartin ,@okumura ,@oliveirg ,@orlando ,@cmorenom ,@paulama ,@serodrig ,@lidiaz as watchers

  • WARNING: big files (>100K) are found in the changeset

    📝 100K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDef.py

    📝 436K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    📝 160K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

  • 📝 The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • CI Result SUCCESS (hash 921d92e9)

    Athena DetCommon
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    DetCommon: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73781]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading